Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2637533003: dart2js-kernel: Call generative constructor body functions (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-kernel: Call generative constructor body functions The generative constructor factory now calls the generative constructor body functions for the superclass chain. The generative constructor body elements are created on demand and compiled via the enqueuer. The call site is currently broken since it does not pass arguments. That will done in a separate CL. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/df1bacb60b3bfc271e329114dfd3befaedf6f13f

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix analyzer warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -76 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 1 1 chunk +45 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 chunks +2 lines, -48 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 13 chunks +67 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
3 years, 11 months ago (2017-01-19 23:58:10 UTC) #3
Emily Fortuna
lgtm
3 years, 11 months ago (2017-01-20 00:38:57 UTC) #4
sra1
3 years, 11 months ago (2017-01-20 03:49:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
df1bacb60b3bfc271e329114dfd3befaedf6f13f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698