[promises] Clean up promise utils and remove dead code

src/builtins/builtins-promise.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stub-assembler.h"
 
 namespace v8 {
 namespace internal {
 
 typedef compiler::Node Node;
 typedef CodeStubAssembler::ParameterMode ParameterMode;
 typedef compiler::CodeAssemblerState CodeAssemblerState;
 
 class PromiseBuiltinsAssembler : public CodeStubAssembler {
  public:
   explicit PromiseBuiltinsAssembler(CodeAssemblerState* state)
       : CodeStubAssembler(state) {}
 
+  enum PromiseResolvingFunctionContextSlot {

[adamk, 2017/01/13 22:45:08]

Style: These enums should go at the top of the public: section, before even the
constructor.

[gsathya, 2017/01/17 16:36:47]

Done.

+    // Whether the resolve/reject callback was already called.
+    kAlreadyVisitedSlot = Context::MIN_CONTEXT_SLOTS,

[adamk, 2017/01/13 22:45:08]

Please add an #include for contexts.h

[gsathya, 2017/01/17 16:36:47]

Done.

+
+    // The promise which resolve/reject callbacks fulfill.
+    kPromiseSlot,
+
+    // Whether to trigger a debug event or not. Used in catch
+    // prediction.
+    kDebugEventSlot,
+    kPromiseContextLength,
+  };
+
+  enum FunctionContextSlot {
+    kCapabilitySlot = Context::MIN_CONTEXT_SLOTS,
+
+    kCapabilitiesContextLength,
+  };
+
   // These allocate and initialize a promise with pending state and
   // undefined fields.
   //
   // This uses undefined as the parent promise for the promise init
   // hook.
   Node* AllocateAndInitJSPromise(Node* context);
   // This uses the given parent as the parent promise for the promise
   // init hook.
   Node* AllocateAndInitJSPromise(Node* context, Node* parent);
 
@@ skipping 61 matching lines @@
 
   void InternalPromiseReject(Node* context, Node* promise, Node* value,
                              Node* debug_event);
 
  private:
   Node* AllocateJSPromise(Node* context);
 };
 
 }  // namespace internal
 }  // namespace v8