Issue 26375004: Unify and fix checkers for duplicate object literal properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26375004: Unify and fix checkers for duplicate object literal properties. (Closed)

Created:
7 years, 2 months ago by Michael Starzinger

Modified:
7 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Unify and fix checkers for duplicate object literal properties. R=ulan@chromium.org TEST=preparser/duplicate-property,mjsunit/regress/regress-parse-object-literal Committed: http://code.google.com/p/v8/source/detail?r=17136

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+355 lines, -413 lines)			Patch
M	src/conversions.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parser.h	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	src/parser.cc	View	1	7 chunks	+52 lines, -134 lines	0 comments	Download
M	src/preparser.h	View		5 chunks	+94 lines, -88 lines	0 comments	Download
M	src/preparser.cc	View		5 chunks	+10 lines, -176 lines	0 comments	Download
M	src/scanner.h	View		3 chunks	+54 lines, -1 line	0 comments	Download
M	src/scanner.cc	View		2 chunks	+140 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-parse-object-literal.js	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	test/preparser/preparser.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

This relands the unification. There is a new regression test for the bug introduced by ...

7 years, 2 months ago (2013-10-10 09:55:04 UTC) #1

Michael Starzinger

7 years, 2 months ago (2013-10-10 11:58:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17136 (presubmit successful).