Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_visitor.dart

Issue 2637483002: Implement switch statement, without the "complex switch statement" (aka switch statement with conti… (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/kernel_visitor.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_visitor.dart b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
index da51f989db9e3c7e1fc07491de9b8dff4734e433..831eff4240e5afda8999c4e2f35331e00b99a2a0 100644
--- a/pkg/compiler/lib/src/kernel/kernel_visitor.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
@@ -848,17 +848,17 @@ class KernelVisitor extends Object
@override
ir.BoolLiteral visitLiteralBool(LiteralBool node) {
- return new ir.BoolLiteral(node.value);
+ return associateNode(new ir.BoolLiteral(node.value), node);
}
@override
ir.DoubleLiteral visitLiteralDouble(LiteralDouble node) {
- return new ir.DoubleLiteral(node.value);
+ return associateNode(new ir.DoubleLiteral(node.value), node);
}
@override
ir.IntLiteral visitLiteralInt(LiteralInt node) {
- return new ir.IntLiteral(node.value);
+ return associateNode(new ir.IntLiteral(node.value), node);
}
@override
@@ -909,7 +909,8 @@ class KernelVisitor extends Object
@override
ir.Expression visitLiteralString(LiteralString node) {
if (node.dartString == null) return new ir.InvalidExpression();
- return new ir.StringLiteral(node.dartString.slowToString());
+ return associateNode(new ir.StringLiteral(node.dartString.slowToString()),
+ node);
}
@override
@@ -1039,8 +1040,10 @@ class KernelVisitor extends Object
}
if (statements.isEmpty || fallsThrough(statements.last)) {
if (isLastCase) {
- statements.add(new ir.BreakStatement(
- getBreakTarget(elements.getTargetDefinition(node))));
+ if (!caseNode.isDefaultCase) {
+ statements.add(new ir.BreakStatement(
+ getBreakTarget(elements.getTargetDefinition(node))));
+ }
} else {
statements.add(new ir.ExpressionStatement(new ir.Throw(
new ir.ConstructorInvocation(
@@ -1243,7 +1246,7 @@ class KernelVisitor extends Object
@override
ir.InvocationExpression visitConstConstructorInvoke(
NewExpression node, ConstructedConstantExpression constant, _) {
- return buildConstructorInvoke(node, isConst: true);
+ return associateNode(buildConstructorInvoke(node, isConst: true), node);
}
@override
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698