Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 the V8 project authors. All rights reserved. | 1 // Copyright 2015 the V8 project authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "src/interpreter/interpreter-intrinsics.h" | 5 #include "src/interpreter/interpreter-intrinsics.h" |
| 6 | 6 |
| 7 #include "src/code-factory.h" | 7 #include "src/code-factory.h" |
| 8 | 8 |
| 9 namespace v8 { | 9 namespace v8 { |
| 10 namespace internal { | 10 namespace internal { |
| (...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 391 | 391 |
| 392 void IntrinsicsHelper::AbortIfArgCountMismatch(int expected, Node* actual) { | 392 void IntrinsicsHelper::AbortIfArgCountMismatch(int expected, Node* actual) { |
| 393 InterpreterAssembler::Label match(assembler_); | 393 InterpreterAssembler::Label match(assembler_); |
| 394 Node* comparison = __ Word32Equal(actual, __ Int32Constant(expected)); | 394 Node* comparison = __ Word32Equal(actual, __ Int32Constant(expected)); |
| 395 __ GotoIf(comparison, &match); | 395 __ GotoIf(comparison, &match); |
| 396 __ Abort(kWrongArgumentCountForInvokeIntrinsic); | 396 __ Abort(kWrongArgumentCountForInvokeIntrinsic); |
| 397 __ Goto(&match); | 397 __ Goto(&match); |
| 398 __ Bind(&match); | 398 __ Bind(&match); |
| 399 } | 399 } |
| 400 | 400 |
| 401 Node* IntrinsicsHelper::CreateAsyncFromSyncIterator(Node* args_reg, | |
| 402 Node* arg_count, | |
| 403 Node* context) { | |
| 404 // TODO(caitp): split AsyncFromSyncIterator functionality out of | |
| 405 // https://codereview.chromium.org/2622833002 | |
| 406 __ CallRuntime(Runtime::kAbort, __ SmiConstant(kGetIterator), | |
| 407 __ NoContextConstant()); | |
|
rmcilroy
2017/01/20 10:34:01
Could we avoid adding this as an intrinsic that ju
neis
2017/01/20 14:38:15
If this will be implemented in a separate CL, plea
caitp
2017/01/20 20:17:19
I would have thought the TODO() indicated this. I
neis
2017/01/24 12:55:45
Sure, but many people read the CL description whil
| |
| 408 return __ UndefinedConstant(); | |
| 409 } | |
| 410 | |
| 401 } // namespace interpreter | 411 } // namespace interpreter |
| 402 } // namespace internal | 412 } // namespace internal |
| 403 } // namespace v8 | 413 } // namespace v8 |
| OLD | NEW |