third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h - Issue 2637343002: Implement WebBluetooth descriptor.readValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)

Patch Set: #3 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-fails.js ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h

index 6a2fc29b1857d5198a7e4a714c80e6d60980b003..b491c1d9860d87043a1fdb276d5202f47223535a 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h

@@ -55,6 +55,10 @@ class BluetoothRemoteGATTDescriptor final

BluetoothRemoteGATTServer* getGatt() { return m_characteristic->getGatt(); }

+ void ReadValueCallback(ScriptPromiseResolver*,

+ mojom::blink::WebBluetoothResult,

+ const Optional<Vector<uint8_t>>&);

mojom::blink::WebBluetoothRemoteGATTDescriptorPtr m_descriptor;

Member<BluetoothRemoteGATTCharacteristic> m_characteristic;

Member<DOMDataView> m_value;