Chromium Code Reviews Chromium Code Reviews
Issue 2637343002:
Implement WebBluetooth descriptor.readValue() (Closed)
| Index: third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html |
| diff --git a/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html b/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..091f2c02f44ce107b5efbda6599b0a86f3cb46af |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html |
| @@ -0,0 +1,25 @@ |
| +<!DOCTYPE html> |
| +<script src="../../../resources/testharness.js"></script> |
| +<script src="../../../resources/testharnessreport.js"></script> |
| +<script src="../../../resources/bluetooth/bluetooth-helpers.js"></script> |
| +<script> |
| +'use strict'; |
| +promise_test(() => { |
| + return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter') |
| + .then(() => requestDeviceWithKeyDown({ |
| + filters: [{services: ['health_thermometer']}]})) |
| + .then(device => device.gatt.connect()) |
| + .then(gattServer => gattServer.getPrimaryService('health_thermometer')) |
| + .then(service => service.getCharacteristic('measurement_interval')) |
| + .then(characteristic => characteristic.getDescriptor('gatt.characteristic_user_description')) |
| + .then(descriptor => { |
| + assert_equals(descriptor.value, null); |
| + return descriptor.readValue() |
| + .then(() => { |
|
ortuno
2017/01/20 04:30:52
nit: align with 't'
dougt
2017/01/23 21:40:36
we use two spaces here
|
| + let decoder = new TextDecoder('utf-8'); |
| + let value_str = decoder.decode(descriptor.value); |
|
ortuno
2017/01/20 04:30:52
can you also assert that the value read is the sam
dougt
2017/01/23 21:40:36
I am not sure what you mean here.
|
| + assert_equals(value_str, "gatt.characteristic_user_description"); |
| + }) |
| + }) |
| +}, 'Succesful read should update descriptor\'s value.'); |
| +</script> |
