Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)
Patch Set: #2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 1b4f4fd8daa8a44e9023c649352fd2a26b2672de..067fda50cdc4b994b0a60a5ea6bf72d62d0303d2 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -341,7 +341,7 @@ class LayoutTestBluetoothAdapterProvider {
// - StartNotifySession: Run success callback.
// - GetProperties: Returns
// BluetoothRemoteGattCharacteristic::PROPERTY_READ
- // - Descriptors
+ // - Descriptors (if |addDescriptor| input is true)
ortuno 2017/01/22 22:04:04 nit: should_add_descriptors or add_descriptors
dougt 2017/01/23 21:40:35 Acknowledged. I am not sure I like using _'s in p
// - User Description (2901)
// - Client Characteristic Configuration (2902)
// Note: This descriptor is blocklisted for writes.
@@ -349,7 +349,7 @@ class LayoutTestBluetoothAdapterProvider {
// A test descriptor that is blocklisted.
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
- GetDisconnectingHealthThermometer();
+ GetDisconnectingHealthThermometer(bool addDescriptor);
// |ServicesDiscoveredAfterReconnectionAdapter|(disconnect)
// Inherits from |HeartRateAdapter|

Powered by Google App Engine
This is Rietveld 408576698