third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp - Issue 2637343002: Implement WebBluetooth descriptor.readValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)

Patch Set: run bad_message_reasons Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h ('k') | third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp

index 7e586e6e56b0fbadaf3b7b51d90e7f450f60cfa0..f41787190932056cd20e7af05e2d2314d00c13be 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp

@@ -35,6 +35,12 @@ DOMException* BluetoothRemoteGATTUtils::CreateDOMException(ExceptionType type) {

"Characteristic is no longer valid. Remember to retrieve the "

"characteristic again after reconnecting.");

+ case ExceptionType::kInvalidDescriptor:

+ return DOMException::create(

+ InvalidStateError,

+ "Descriptor is no longer valid. Remember to retrieve the "

+ "Descriptor again after reconnecting.");

default:

NOTREACHED();

return nullptr;