third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp - Issue 2637343002: Implement WebBluetooth descriptor.readValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)

Patch Set: run bad_message_reasons Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

index 82c8b229ed9fc8797658ecea25e6f649649cbbad..ae16eb421cb46c9319fb6d29f2cf38a692950f40 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

@@ -57,8 +57,7 @@ void BluetoothRemoteGATTService::GetCharacteristicsCallback(

resolver->getExecutionContext()->isContextDestroyed())

return;

- // If the resolver is not in the set of ActiveAlgorithms then the frame

- // disconnected so we reject.

+ // If the device is disconnected, reject.

if (!device()->gatt()->RemoveFromActiveAlgorithms(resolver)) {

resolver->reject(

DOMException::create(NetworkError, kGATTServerDisconnected));

@@ -129,7 +128,6 @@ ScriptPromise BluetoothRemoteGATTService::getCharacteristicsImpl(

ScriptState* scriptState,

mojom::blink::WebBluetoothGATTQueryQuantity quantity,

const String& characteristicsUUID) {

- // We always check that the device is connected.

if (!device()->gatt()->connected()) {

return ScriptPromise::rejectWithDOMException(

scriptState,