Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: content/browser/bluetooth/bluetooth_metrics.cc

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)
Patch Set: run bad_message_reasons Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/bluetooth_metrics.cc
diff --git a/content/browser/bluetooth/bluetooth_metrics.cc b/content/browser/bluetooth/bluetooth_metrics.cc
index c32c9cf01abf13702070eb8d60988c15a6f5fe71..d33f130d0eca3f877c96cf3ae6d7b25856b94fc6 100644
--- a/content/browser/bluetooth/bluetooth_metrics.cc
+++ b/content/browser/bluetooth/bluetooth_metrics.cc
@@ -243,6 +243,7 @@ void RecordGetCharacteristicsOutcome(
UMAGetCharacteristicOutcome::NO_SERVICE);
return;
case CacheQueryOutcome::NO_CHARACTERISTIC:
+ case CacheQueryOutcome::NO_DESCRIPTOR:
NOTREACHED();
return;
}
@@ -279,6 +280,9 @@ void RecordGATTOperationOutcome(UMAGATTOperation operation,
case UMAGATTOperation::START_NOTIFICATIONS:
RecordStartNotificationsOutcome(outcome);
return;
+ case UMAGATTOperation::DESCRIPTOR_READ:
+ // TODO(667319) Add reporting to descriptors
+ return;
case UMAGATTOperation::COUNT:
NOTREACHED();
return;
@@ -300,6 +304,8 @@ static UMAGATTOperationOutcome TranslateCacheQueryOutcomeToGATTOperationOutcome(
return UMAGATTOperationOutcome::NO_SERVICE;
case CacheQueryOutcome::NO_CHARACTERISTIC:
return UMAGATTOperationOutcome::NO_CHARACTERISTIC;
+ case CacheQueryOutcome::NO_DESCRIPTOR:
+ return UMAGATTOperationOutcome::NO_DESCRIPTOR;
}
NOTREACHED() << "No need to record success or renderer crash";
return UMAGATTOperationOutcome::NOT_SUPPORTED;
« no previous file with comments | « content/browser/bluetooth/bluetooth_metrics.h ('k') | content/browser/bluetooth/web_bluetooth_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698