Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)
Patch Set: #4 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
index 89a1ea228b9310bb9b7cfa6293570c69c9dac058..ff47d23d5f0c6e83054a62e600d21a8af17c9c35 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
@@ -122,7 +122,6 @@ void BluetoothRemoteGATTCharacteristic::ReadValueCallback(
ScriptPromise BluetoothRemoteGATTCharacteristic::readValue(
ScriptState* scriptState) {
- // We always check that the device is connected.
if (!getGatt()->connected()) {
return ScriptPromise::rejectWithDOMException(
scriptState,
@@ -179,7 +178,6 @@ void BluetoothRemoteGATTCharacteristic::WriteValueCallback(
ScriptPromise BluetoothRemoteGATTCharacteristic::writeValue(
ScriptState* scriptState,
const DOMArrayPiece& value) {
- // We always check that the device is connected.
if (!getGatt()->connected()) {
return ScriptPromise::rejectWithDOMException(
scriptState,
@@ -248,7 +246,6 @@ void BluetoothRemoteGATTCharacteristic::NotificationsCallback(
ScriptPromise BluetoothRemoteGATTCharacteristic::startNotifications(
ScriptState* scriptState) {
- // We always check that the device is connected.
if (!getGatt()->connected()) {
return ScriptPromise::rejectWithDOMException(
scriptState,
@@ -280,7 +277,6 @@ ScriptPromise BluetoothRemoteGATTCharacteristic::startNotifications(
ScriptPromise BluetoothRemoteGATTCharacteristic::stopNotifications(
ScriptState* scriptState) {
- // We always check that the device is connected.
if (!getGatt()->connected()) {
return ScriptPromise::rejectWithDOMException(
scriptState,
« content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698