third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html - Issue 2637343002: Implement WebBluetooth descriptor.readValue()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)

Patch Set: #3 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('K') | « third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-succeeds.html ('k') | third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/descriptor-is-blocklisted.js » ('j') | third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/descriptor-is-blocklisted.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 promise_test(() => {

	8 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')

	9 .then(() => requestDeviceWithKeyDown({

	10 filters: [{services: ['health_thermometer']}]}))

	11 .then(device => device.gatt.connect())

	12 .then(gattServer => gattServer.getPrimaryService('health_thermometer'))

	13 .then(service => service.getCharacteristic('measurement_interval'))

	14 .then(characteristic => characteristic.getDescriptor(user_description.name))

	15 .then(descriptor => {

	16 assert_equals(descriptor.value, null);

	17 return descriptor.readValue()

	18 .then(() => {

	19 let decoder = new TextDecoder('utf-8');
	ortuno 2017/01/23 22:20:42 hmm maybe we need a separate test for this but thi hmm maybe we need a separate test for this but this is what I meant: return descriptor.readValue() .then(value => { assert_equals(value, descriptor.value); let decoder = ... }) }); dougt 2017/01/24 00:26:24 Done. Show quoted text On 2017/01/23 22:20:42, ortuno wrote: > hmm maybe we need a separate test for this but this is what I meant: > > return descriptor.readValue() > .then(value => { > assert_equals(value, descriptor.value); > let decoder = ... > }) > }); Done.
	20 let value_str = decoder.decode(descriptor.value);

	21 assert_equals(value_str, "gatt.characteristic_user_description");

	22 })
	ortuno 2017/01/23 22:20:42 nit: Missing ';' nit: Missing ';' dougt 2017/01/24 00:26:24 Done. Show quoted text On 2017/01/23 22:20:42, ortuno wrote: > nit: Missing ';' Done.
	23 })
	ortuno 2017/01/23 22:20:42 nit: Missing ';' nit: Missing ';' dougt 2017/01/24 00:26:24 Done. Show quoted text On 2017/01/23 22:20:42, ortuno wrote: > nit: Missing ';' Done.
	24 }, 'Succesful read should update descriptor\'s value.');

	25 </script>

OLD	NEW