Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/script-tests/descriptor/io-op-reconnect-during-success.js

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)
Patch Set: #2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 promise_test(
ortuno 2017/01/20 04:30:53 out of curiosity: Why are these no longer called g
dougt 2017/01/23 21:40:36 These are just going to be for read/write. I figu
2 () => {
3 let val = new Uint8Array([1]);
4 return setBluetoothFakeAdapter(
5 'GATTOperationSucceedsAfterReconnectionAdapter')
6 .then(
7 () => requestDeviceWithKeyDown(
ortuno 2017/01/20 04:30:53 Same here. Move to previous line. Same for other t
dougt 2017/01/23 21:40:36 Acknowledged.
8 {filters: [{services: ['health_thermometer']}]}))
9 .then(device => device.gatt.connect())
10 .then(gatt => gatt.getPrimaryService('health_thermometer'))
11 .then(service => service.getCharacteristic('measurement_interval'))
12 .then(
13 characteristic => characteristic.getDescriptor(
ortuno 2017/01/20 04:30:53 move to previous line. Same for other tests.
dougt 2017/01/23 21:40:36 Acknowledged.
14 'gatt.characteristic_user_description'))
15 .then(descriptor => {
16 let promise = assert_promise_rejects_with_message(
17 descriptor.CALLS([readValue()]),
18 new DOMException(
19 'GATT Server disconnected while performing a GATT operation. ',
20 'NetworkError'));
21 let gatt = descriptor.characteristic.service.device.gatt;
22 gatt.disconnect();
23 return gatt.connect().then(() => promise);
24 });
25 },
26 'disconnect() and connect() called during a FUNCTION_NAME call that ' +
ortuno 2017/01/20 04:30:53 nit: Move to previous line. Same for other tests.
dougt 2017/01/23 21:40:36 Acknowledged.
27 'succeeds. Reject with NetworkError.');
ortuno 2017/01/20 04:30:53 nit: align with ' from previous line. Same for oth
dougt 2017/01/23 21:40:36 Acknowledged.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698