third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-fails.html - Issue 2637343002: Implement WebBluetooth descriptor.readValue()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-fails.html

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)

Patch Set: #2 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	ortuno 2017/01/22 22:04:04 I think we can share this test with writeValue. I think we can share this test with writeValue. dougt 2017/01/23 21:40:36 Done. Show quoted text On 2017/01/22 22:04:04, ortuno wrote: > I think we can share this test with writeValue. Done.
	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script>

	6 'use strict';

	7 promise_test(() => {

	8 return setBluetoothFakeAdapter('FailingGATTOperationsAdapter')

	9 .then(() => requestDeviceWithKeyDown({

	10 filters: [{services: [errorUUID(0xA0)]}]}))

	11 .then(device => device.gatt.connect())

	12 .then(gattServer => gattServer.getPrimaryService(errorUUID(0xA0)))

	13 .then(service => {

	14 service.getCharacteristic(errorUUID(0xA1))

	15 .then(characteristic => {

	16 let tests = Promise.resolve();

	17 gatt_errors_tests.forEach(testSpec => {

	18 tests = tests.then(() => characteristic.getDescriptor(testSpec.uuid))

	19 .then(descriptor => assert_promise_rejects_with_message(

	20 descriptor.readValue(),

	21 testSpec.error,

	22 testSpec.testName));

	23 });

	24 return tests;

	25 })

	26 })

	27 }, 'Read fails. Should reject with appropriate error.');

	28 </script>

OLD	NEW