Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2738)

Unified Diff: android_webview/browser/browser_view_renderer_unittest.cc

Issue 2637273002: [android_webview] Do not declare WebView visible on detaching from window. (Closed)
Patch Set: Fixed comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/browser_view_renderer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer_unittest.cc
diff --git a/android_webview/browser/browser_view_renderer_unittest.cc b/android_webview/browser/browser_view_renderer_unittest.cc
index 586f7cce2820d0fcb812319582963803020b3ccd..4db9e9149b592cb1d50b252d5bfb0048a9e77fd1 100644
--- a/android_webview/browser/browser_view_renderer_unittest.cc
+++ b/android_webview/browser/browser_view_renderer_unittest.cc
@@ -291,6 +291,54 @@ class CompositorNoFrameTest : public RenderingTest {
RENDERING_TEST_F(CompositorNoFrameTest);
+class ClientIsVisibleOnConstructionTest : public RenderingTest {
+ void SetUpTestHarness() override {
+ browser_view_renderer_.reset(
+ new BrowserViewRenderer(this, base::ThreadTaskRunnerHandle::Get()));
+ }
+
+ void StartTest() override {
+ EXPECT_FALSE(browser_view_renderer_->attached_to_window());
+ EXPECT_FALSE(browser_view_renderer_->window_visible_for_tests());
+ EXPECT_TRUE(browser_view_renderer_->IsClientVisible());
+ EndTest();
+ }
+};
+
+RENDERING_TEST_F(ClientIsVisibleOnConstructionTest);
+
+class ClientIsVisibleAfterAttachTest : public RenderingTest {
+ void StartTest() override {
+ EXPECT_TRUE(browser_view_renderer_->attached_to_window());
+ EXPECT_TRUE(browser_view_renderer_->window_visible_for_tests());
+
+ EXPECT_TRUE(browser_view_renderer_->IsClientVisible());
+ EndTest();
+ }
+};
+
+RENDERING_TEST_F(ClientIsVisibleAfterAttachTest);
+
+class ClientIsInvisibleAfterWindowGoneTest : public RenderingTest {
+ void StartTest() override {
+ browser_view_renderer_->SetWindowVisibility(false);
+ EXPECT_FALSE(browser_view_renderer_->IsClientVisible());
+ EndTest();
+ }
+};
+
+RENDERING_TEST_F(ClientIsInvisibleAfterWindowGoneTest);
+
+class ClientIsInvisibleAfterDetachTest : public RenderingTest {
+ void StartTest() override {
+ browser_view_renderer_->OnDetachedFromWindow();
+ EXPECT_FALSE(browser_view_renderer_->IsClientVisible());
+ EndTest();
+ }
+};
+
+RENDERING_TEST_F(ClientIsInvisibleAfterDetachTest);
+
class ResourceRenderingTest : public RenderingTest {
public:
using ResourceCountMap = std::map<cc::ResourceId, int>;
« no previous file with comments | « android_webview/browser/browser_view_renderer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698