Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 26372006: Replace cubic round rect corners with quads (Closed)

Created:
7 years, 2 months ago by robertphillips
Modified:
7 years, 2 months ago
Reviewers:
f(malita), reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Whenever Chromium needs an inverse RR clip it goes down this code path and gives us a path with cubics.

Patch Set 1 #

Patch Set 2 : cleaned up #

Total comments: 4

Patch Set 3 : Put change behind flag #

Patch Set 4 : added suppressions #

Patch Set 5 : base files missing retry #

Patch Set 6 : base files missing retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -84 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 7 chunks +128 lines, -82 lines 0 comments Download
M src/core/SkPathRef.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
https://codereview.chromium.org/26372006/diff/2001/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.chromium.org/26372006/diff/2001/src/core/SkPath.cpp#newcode901 src/core/SkPath.cpp:901: Just moved up from below https://codereview.chromium.org/26372006/diff/2001/src/core/SkPath.cpp#newcode964 src/core/SkPath.cpp:964: Not overjoyed ...
7 years, 2 months ago (2013-10-16 14:49:57 UTC) #1
f(malita)
As far as Blink side effects go, we should probably land this behind a flag ...
7 years, 2 months ago (2013-10-16 15:04:01 UTC) #2
robertphillips
Now behind a flag.
7 years, 2 months ago (2013-10-16 15:17:35 UTC) #3
f(malita)
lgtm
7 years, 2 months ago (2013-10-16 18:01:04 UTC) #4
robertphillips
committed as r11835
7 years, 2 months ago (2013-10-17 12:17:46 UTC) #5
robertphillips
This was reverted in r11841 due to performance regressions
7 years, 2 months ago (2013-10-17 16:29:57 UTC) #6
robertphillips
7 years, 2 months ago (2013-10-21 12:57:37 UTC) #7
Message was sent while issue was closed.
This was completed (regression fixed) in r11870. Please see:

Fix cubic->quad RR corner regression https://codereview.chromium.org/29673002/

Powered by Google App Engine
This is Rietveld 408576698