runtime/vm/intermediate_language.cc - Issue 2637173003: VM: Fix [StringInterpolateInstr]s canonicalization: null.ToString() should return "null" (not "Null…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 2637173003: VM: Fix [StringInterpolateInstr]s canonicalization: null.ToString() should return "null" (not "Null… (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language.cc

diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc

index 78675d997f146eea70050cdb8e44299b502e9ff2..007cb3655f06fd173b5e8db0088c2eb0ef049d0e 100644

--- a/runtime/vm/intermediate_language.cc

+++ b/runtime/vm/intermediate_language.cc

@@ -3611,7 +3611,7 @@ Definition* StringInterpolateInstr::Canonicalize(FlowGraph* flow_graph) {

pieces.SetAt(store_index, Bool::Cast(obj).value() ? Symbols::True()

: Symbols::False());

} else if (obj.IsNull()) {

- pieces.SetAt(store_index, Symbols::Null());

+ pieces.SetAt(store_index, Symbols::null());

} else {

return this;

}

« no previous file with comments | « no previous file | runtime/vm/symbols.h » ('j') | no next file with comments »