Issue 2637173003: VM: Fix [StringInterpolateInstr]s canonicalization: null.ToString() should return "null" (not "Null…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2637173003: VM: Fix [StringInterpolateInstr]s canonicalization: null.ToString() should return "null" (not "Null… (Closed)

Created:
3 years, 11 months ago by kustermann

Modified:
3 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google), Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix [StringInterpolateInstr]s canonicalization: null.ToString() should return "null" (not "Null") R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/46449727a62dff2c4a16507a9018ca20a8c50744

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/vm/intermediate_language.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/symbols.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

kustermann

There is already a test testing this functionality (namely `tests/language/null_test.dart`), but the VM doesn't hit ...

3 years, 11 months ago (2017-01-17 18:26:12 UTC) #3

kustermann

3 years, 11 months ago (2017-01-18 09:21:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
46449727a62dff2c4a16507a9018ca20a8c50744 (presubmit successful).