Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1658)

Unified Diff: chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc

Issue 2637163002: Defer ARC file system operations while ARC is booting. (Closed)
Patch Set: Review ready. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
diff --git a/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc b/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
index 2ba11180120e0cf3dece724cdd938029dc8237c3..f5b732000a0a67b5b49dc1f5cabfacc02f88941a 100644
--- a/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
+++ b/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
@@ -14,7 +14,7 @@
#include "chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.h"
#include "components/arc/arc_bridge_service.h"
#include "components/arc/arc_service_manager.h"
-#include "components/arc/test/fake_file_system_instance.h"
+#include "components/arc/file_system/test/fake_arc_file_system_operation_runner.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "mojo/edk/embedder/embedder.h"
#include "net/base/io_buffer.h"
@@ -52,12 +52,14 @@ bool ReadData(ArcContentFileSystemFileStreamReader* reader,
return true;
}
-class ArcFileSystemInstanceTestImpl : public FakeFileSystemInstance {
+class ArcFileSystemOperationRunnerForTest
+ : public FakeArcFileSystemOperationRunner {
public:
- explicit ArcFileSystemInstanceTestImpl(const base::FilePath& file_path)
- : file_path_(file_path) {}
-
- ~ArcFileSystemInstanceTestImpl() override = default;
+ ArcFileSystemOperationRunnerForTest(ArcBridgeService* bridge_service,
+ const base::FilePath& file_path)
+ : FakeArcFileSystemOperationRunner(bridge_service),
+ file_path_(file_path) {}
+ ~ArcFileSystemOperationRunnerForTest() override = default;
void GetFileSize(const std::string& url,
const GetFileSizeCallback& callback) override {
@@ -125,7 +127,7 @@ class ArcFileSystemInstanceTestImpl : public FakeFileSystemInstance {
base::FilePath file_path_;
- DISALLOW_COPY_AND_ASSIGN(ArcFileSystemInstanceTestImpl);
+ DISALLOW_COPY_AND_ASSIGN(ArcFileSystemOperationRunnerForTest);
};
class ArcContentFileSystemFileStreamReaderTest : public testing::Test {
@@ -140,18 +142,16 @@ class ArcContentFileSystemFileStreamReaderTest : public testing::Test {
base::FilePath path = temp_dir_.GetPath().AppendASCII("bar");
ASSERT_TRUE(base::WriteFile(path, kData, arraysize(kData)));
- file_system_ = base::MakeUnique<ArcFileSystemInstanceTestImpl>(path);
-
arc_service_manager_ = base::MakeUnique<ArcServiceManager>(nullptr);
- arc_service_manager_->arc_bridge_service()->file_system()->SetInstance(
- file_system_.get());
+ arc_service_manager_->AddService(
+ base::MakeUnique<ArcFileSystemOperationRunnerForTest>(
+ arc_service_manager_->arc_bridge_service(), path));
}
private:
base::ScopedTempDir temp_dir_;
content::TestBrowserThreadBundle thread_bundle_;
std::unique_ptr<ArcServiceManager> arc_service_manager_;
- std::unique_ptr<ArcFileSystemInstanceTestImpl> file_system_;
DISALLOW_COPY_AND_ASSIGN(ArcContentFileSystemFileStreamReaderTest);
};

Powered by Google App Engine
This is Rietveld 408576698