Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Side by Side Diff: chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc

Issue 2637163002: Defer ARC file system operations while ARC is booting. (Closed)
Patch Set: Review ready. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.h" 5 #include "chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_u til.h"
6 6
7 #include <string>
8 #include <utility>
9 #include <vector>
10
11 #include "base/optional.h"
12 #include "components/arc/arc_bridge_service.h"
13 #include "components/arc/arc_service_manager.h" 7 #include "components/arc/arc_service_manager.h"
8 #include "components/arc/file_system/arc_file_system_operation_runner.h"
14 #include "content/public/browser/browser_thread.h" 9 #include "content/public/browser/browser_thread.h"
15 #include "url/gurl.h"
16
17 #define GET_FILE_SYSTEM_INSTANCE(method_name) \
18 (arc::ArcServiceManager::Get() \
19 ? ARC_GET_INSTANCE_FOR_METHOD(arc::ArcServiceManager::Get() \
20 ->arc_bridge_service() \
21 ->file_system(), \
22 method_name) \
23 : nullptr)
24 10
25 using content::BrowserThread; 11 using content::BrowserThread;
26 12
27 namespace arc { 13 namespace arc {
28 14
29 namespace file_system_instance_util { 15 namespace file_system_operation_runner_util {
30 16
31 namespace { 17 namespace {
32 18
33 template <typename T> 19 template <typename T>
34 void PostToIOThread(const base::Callback<void(T)>& callback, T result) { 20 void PostToIOThread(const base::Callback<void(T)>& callback, T result) {
35 DCHECK_CURRENTLY_ON(BrowserThread::UI); 21 DCHECK_CURRENTLY_ON(BrowserThread::UI);
36 BrowserThread::PostTask( 22 BrowserThread::PostTask(
37 BrowserThread::IO, FROM_HERE, 23 BrowserThread::IO, FROM_HERE,
38 base::Bind(callback, base::Passed(std::move(result)))); 24 base::Bind(callback, base::Passed(std::move(result))));
39 } 25 }
40 26
41 void GetFileSizeOnUIThread(const GURL& arc_url, 27 void GetFileSizeOnUIThread(const std::string& url,
42 const GetFileSizeCallback& callback) { 28 const GetFileSizeCallback& callback) {
43 DCHECK_CURRENTLY_ON(BrowserThread::UI); 29 DCHECK_CURRENTLY_ON(BrowserThread::UI);
44 auto* file_system_instance = GET_FILE_SYSTEM_INSTANCE(GetFileSize); 30 auto* runner =
45 if (!file_system_instance) { 31 ArcServiceManager::GetGlobalService<ArcFileSystemOperationRunner>();
32 if (!runner) {
46 callback.Run(-1); 33 callback.Run(-1);
47 return;
48 } 34 }
49 file_system_instance->GetFileSize(arc_url.spec(), callback); 35 runner->GetFileSize(url, callback);
50 } 36 }
51 37
52 void OpenFileToReadOnUIThread(const GURL& arc_url, 38 void OpenFileToReadOnUIThread(const std::string& url,
53 const OpenFileToReadCallback& callback) { 39 const OpenFileToReadCallback& callback) {
54 DCHECK_CURRENTLY_ON(BrowserThread::UI); 40 DCHECK_CURRENTLY_ON(BrowserThread::UI);
55 auto* file_system_instance = GET_FILE_SYSTEM_INSTANCE(OpenFileToRead); 41 auto* runner =
56 if (!file_system_instance) { 42 ArcServiceManager::GetGlobalService<ArcFileSystemOperationRunner>();
43 if (!runner) {
57 callback.Run(mojo::ScopedHandle()); 44 callback.Run(mojo::ScopedHandle());
58 return; 45 return;
59 } 46 }
60 file_system_instance->OpenFileToRead(arc_url.spec(), callback); 47 runner->OpenFileToRead(url, callback);
61 } 48 }
62 49
63 void GetDocumentOnUIThread(const std::string& authority, 50 void GetDocumentOnUIThread(const std::string& authority,
64 const std::string& document_id, 51 const std::string& document_id,
65 const GetDocumentCallback& callback) { 52 const GetDocumentCallback& callback) {
66 DCHECK_CURRENTLY_ON(BrowserThread::UI); 53 DCHECK_CURRENTLY_ON(BrowserThread::UI);
67 auto* file_system_instance = GET_FILE_SYSTEM_INSTANCE(GetDocument); 54 auto* runner =
68 if (!file_system_instance) { 55 ArcServiceManager::GetGlobalService<ArcFileSystemOperationRunner>();
56 if (!runner) {
69 callback.Run(mojom::DocumentPtr()); 57 callback.Run(mojom::DocumentPtr());
70 return; 58 return;
71 } 59 }
72 file_system_instance->GetDocument(authority, document_id, callback); 60 runner->GetDocument(authority, document_id, callback);
73 } 61 }
74 62
75 void GetChildDocumentsOnUIThread(const std::string& authority, 63 void GetChildDocumentsOnUIThread(const std::string& authority,
76 const std::string& parent_document_id, 64 const std::string& parent_document_id,
77 const GetChildDocumentsCallback& callback) { 65 const GetChildDocumentsCallback& callback) {
78 DCHECK_CURRENTLY_ON(BrowserThread::UI); 66 DCHECK_CURRENTLY_ON(BrowserThread::UI);
79 auto* file_system_instance = GET_FILE_SYSTEM_INSTANCE(GetChildDocuments); 67 auto* runner =
80 if (!file_system_instance) { 68 ArcServiceManager::GetGlobalService<ArcFileSystemOperationRunner>();
69 if (!runner) {
81 callback.Run(base::nullopt); 70 callback.Run(base::nullopt);
82 return; 71 return;
83 } 72 }
84 file_system_instance->GetChildDocuments(authority, parent_document_id, 73 runner->GetChildDocuments(authority, parent_document_id, callback);
85 callback);
86 } 74 }
87 75
88 } // namespace 76 } // namespace
89 77
90 void GetFileSizeOnIOThread(const GURL& arc_url, 78 void GetFileSizeOnIOThread(const std::string& url,
91 const GetFileSizeCallback& callback) { 79 const GetFileSizeCallback& callback) {
92 DCHECK_CURRENTLY_ON(BrowserThread::IO); 80 DCHECK_CURRENTLY_ON(BrowserThread::IO);
93 BrowserThread::PostTask( 81 BrowserThread::PostTask(
94 BrowserThread::UI, FROM_HERE, 82 BrowserThread::UI, FROM_HERE,
95 base::Bind(&GetFileSizeOnUIThread, arc_url, 83 base::Bind(&GetFileSizeOnUIThread, url,
96 base::Bind(&PostToIOThread<int64_t>, callback))); 84 base::Bind(&PostToIOThread<int64_t>, callback)));
97 } 85 }
98 86
99 void OpenFileToReadOnIOThread(const GURL& arc_url, 87 void OpenFileToReadOnIOThread(const std::string& url,
100 const OpenFileToReadCallback& callback) { 88 const OpenFileToReadCallback& callback) {
101 DCHECK_CURRENTLY_ON(BrowserThread::IO); 89 DCHECK_CURRENTLY_ON(BrowserThread::IO);
102 BrowserThread::PostTask( 90 BrowserThread::PostTask(
103 BrowserThread::UI, FROM_HERE, 91 BrowserThread::UI, FROM_HERE,
104 base::Bind(&OpenFileToReadOnUIThread, arc_url, 92 base::Bind(&OpenFileToReadOnUIThread, url,
105 base::Bind(&PostToIOThread<mojo::ScopedHandle>, callback))); 93 base::Bind(&PostToIOThread<mojo::ScopedHandle>, callback)));
106 } 94 }
107 95
108 void GetDocumentOnIOThread(const std::string& authority, 96 void GetDocumentOnIOThread(const std::string& authority,
109 const std::string& document_id, 97 const std::string& document_id,
110 const GetDocumentCallback& callback) { 98 const GetDocumentCallback& callback) {
111 DCHECK_CURRENTLY_ON(BrowserThread::IO); 99 DCHECK_CURRENTLY_ON(BrowserThread::IO);
112 BrowserThread::PostTask( 100 BrowserThread::PostTask(
113 BrowserThread::UI, FROM_HERE, 101 BrowserThread::UI, FROM_HERE,
114 base::Bind(&GetDocumentOnUIThread, authority, document_id, 102 base::Bind(&GetDocumentOnUIThread, authority, document_id,
115 base::Bind(&PostToIOThread<mojom::DocumentPtr>, callback))); 103 base::Bind(&PostToIOThread<mojom::DocumentPtr>, callback)));
116 } 104 }
117 105
118 void GetChildDocumentsOnIOThread(const std::string& authority, 106 void GetChildDocumentsOnIOThread(const std::string& authority,
119 const std::string& parent_document_id, 107 const std::string& parent_document_id,
120 const GetChildDocumentsCallback& callback) { 108 const GetChildDocumentsCallback& callback) {
121 DCHECK_CURRENTLY_ON(BrowserThread::IO); 109 DCHECK_CURRENTLY_ON(BrowserThread::IO);
122 BrowserThread::PostTask( 110 BrowserThread::PostTask(
123 BrowserThread::UI, FROM_HERE, 111 BrowserThread::UI, FROM_HERE,
124 base::Bind( 112 base::Bind(
125 &GetChildDocumentsOnUIThread, authority, parent_document_id, 113 &GetChildDocumentsOnUIThread, authority, parent_document_id,
126 base::Bind( 114 base::Bind(
127 &PostToIOThread<base::Optional<std::vector<mojom::DocumentPtr>>>, 115 &PostToIOThread<base::Optional<std::vector<mojom::DocumentPtr>>>,
128 callback))); 116 callback)));
129 } 117 }
130 118
131 } // namespace file_system_instance_util 119 } // namespace file_system_operation_runner_util
132 120
133 } // namespace arc 121 } // namespace arc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698