chrome/browser/BUILD.gn - Issue 2637153002: Submit a sample of notification images to Safe Browsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 2637153002: Submit a sample of notification images to Safe Browsing (Closed)

Patch Set: Changed the Finch to be a params based trial. Also addressed nits. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 0ff9de15da13f2c6bc97ada8af4cdcf4b5faed2c..9ab8ceaeccee2efa2ddfd790d5013a87b0c89a5a 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -1992,6 +1992,8 @@ split_static_library("browser") {

"safe_browsing/certificate_reporting_service.h",

"safe_browsing/certificate_reporting_service_factory.cc",

"safe_browsing/certificate_reporting_service_factory.h",

+ "safe_browsing/notification_image_reporter.cc",

+ "safe_browsing/notification_image_reporter.h",

"safe_browsing/permission_reporter.cc",

"safe_browsing/permission_reporter.h",

"safe_browsing/ping_manager.cc",