tools/metrics/histograms/histograms.xml - Issue 2637153002: Submit a sample of notification images to Safe Browsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2637153002: Submit a sample of notification images to Safe Browsing (Closed)

Patch Set: Changed the Finch to be a params based trial. Also addressed nits. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 5ff826f91882fdafd855d07aba96a376fed17b42..d659a9fb794b5104a2d51c456b401a9558298c47 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -54420,6 +54420,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="SafeBrowsing.NotificationImageReporter.NetError"

+ enum="NetErrorCodes">

+ <owner>nparker@chromium.org</owner>

+ <summary>

+ The net error code for reports sent by NotificationImageReporter.

Nathan Parker 2017/01/20 21:18:49 add: Logged for failed reports.

harkness 2017/01/23 11:30:10 This is actually logged for both successful and fa

johnme 2017/01/23 11:34:34 Nit: Perhaps add "or net:OK if successful" to clar

harkness 2017/01/23 11:45:56 Done.

+ </summary>

+</histogram>

<histogram name="SafeBrowsing.ParseV4HashResult"

enum="SafeBrowsingParseV4HashResult">