Issue 2637103002: Update `String.replaceFirstMapped`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2637103002: Update `String.replaceFirstMapped`. (Closed)

Created:
3 years, 11 months ago by floitsch

Modified:
3 years, 11 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update `String.replaceFirstMapped`. Fixes #28311 BUG= http://dartbug.com/28311 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/626cd0a4d4f9473bcb3dc7821e3c92a409461f5f

Patch Set 1 #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	sdk/lib/core/string.dart	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/2637103002/diff/1/sdk/lib/core/string.dart File sdk/lib/core/string.dart (right): https://codereview.chromium.org/2637103002/diff/1/sdk/lib/core/string.dart#newcode432 sdk/lib/core/string.dart:432: * an integer in the range `[0 .. len]`, ...

3 years, 11 months ago (2017-01-17 15:59:48 UTC) #3

floitsch

3 years, 11 months ago (2017-01-18 12:55:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
626cd0a4d4f9473bcb3dc7821e3c92a409461f5f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages