include/effects/SkXfermodeImageFilter.h - Issue 26371002: Change SkImageFilter's cropRect from SkIRect to a CropRect struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkXfermodeImageFilter.h

Issue 26371002: Change SkImageFilter's cropRect from SkIRect to a CropRect struct (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Alternate version, using a single fFlags member. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkXfermodeImageFilter.h

diff --git a/include/effects/SkXfermodeImageFilter.h b/include/effects/SkXfermodeImageFilter.h

index 4a5d7fa8c5e4dd4cdeeaa27e61df02d1cf57ed92..6343c4b575f13aed4cb9f43ce8e859af3850d726 100644

--- a/include/effects/SkXfermodeImageFilter.h

+++ b/include/effects/SkXfermodeImageFilter.h

@@ -22,7 +22,7 @@ class SK_API SkXfermodeImageFilter : public SkImageFilter {

public:

SkXfermodeImageFilter(SkXfermode* mode, SkImageFilter* background,

- SkImageFilter* foreground = NULL, const SkIRect* cropRect = NULL);

+ SkImageFilter* foreground = NULL, const CropRect* cropRect = NULL);

virtual ~SkXfermodeImageFilter();

@@ -34,7 +34,7 @@ public:

SkBitmap* dst,

SkIPoint* offset) SK_OVERRIDE;

#if SK_SUPPORT_GPU

- virtual bool canFilterImageGPU() const SK_OVERRIDE { return cropRect().isLargest(); }

+ virtual bool canFilterImageGPU() const SK_OVERRIDE { return !cropRectIsSet(); }

virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const SkMatrix& ctm,

SkBitmap* result, SkIPoint* offset) SK_OVERRIDE;

#endif

« no previous file with comments | « include/effects/SkOffsetImageFilter.h ('k') | src/core/SkImageFilter.cpp » ('j') | no next file with comments »