Issue 2637083002: Use `List::filled` instead of `List::` in closure conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2637083002: Use `List::filled` instead of `List::` in closure conversion (Closed)

Created:
3 years, 11 months ago by karlklose

Modified:
3 years, 11 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use `List::filled` instead of `List::` in closure conversion The redirecting factory List:: is currently removed and replaced with the actual target at the callsites during construction of kernel, but referencing the actual target here would make the transformation platform specific. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/8c6a17409195174ebd734987ca024ac29ce23e35

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -7 lines)			Patch
M	pkg/kernel/lib/transformations/closure/mock.dart	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	pkg/kernel/testcases/closures/capture_closure.dart.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/testcases/closures/capture_closure_parameter.dart.expect	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/testcases/closures/named_closure.dart.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/testcases/closures/type_variables.dart.expect	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

karlklose

3 years, 11 months ago (2017-01-17 14:17:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c6a17409195174ebd734987ca024ac29ce23e35 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages