Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/core/fetch/RawResource.h

Issue 2637063002: Use MockResource as much as possibler in MemoryCacheCorrectnessTest (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/RawResource.h
diff --git a/third_party/WebKit/Source/core/fetch/RawResource.h b/third_party/WebKit/Source/core/fetch/RawResource.h
index bd34d00ef4daec90f6bc876ec3cff5ccf0d5b888..07d8cecd36d1e8f2123d71dd539d24d0d80f552b 100644
--- a/third_party/WebKit/Source/core/fetch/RawResource.h
+++ b/third_party/WebKit/Source/core/fetch/RawResource.h
@@ -40,7 +40,7 @@ class CORE_EXPORT RawResource final : public Resource {
public:
using ClientType = RawResourceClient;
- static Resource* fetchSynchronously(FetchRequest&, ResourceFetcher*);
+ static RawResource* fetchSynchronously(FetchRequest&, ResourceFetcher*);
static RawResource* fetch(FetchRequest&, ResourceFetcher*);
static RawResource* fetchMainResource(FetchRequest&,
ResourceFetcher*,
@@ -63,6 +63,9 @@ class CORE_EXPORT RawResource final : public Resource {
bool canReuse(const ResourceRequest&) const override;
+ bool willFollowRedirect(const ResourceRequest&,
hiroshige 2017/01/17 19:28:42 Could you add a comment that states this is expose
yhirano 2017/01/18 05:58:37 Hmm, I don't see much value in hidding functions t
Takashi Toyoshima 2017/01/19 04:08:20 Agreed with yhirano here. I'd submit this patch as
+ const ResourceResponse&) override;
+
private:
class RawResourceFactory : public ResourceFactory {
public:
@@ -84,8 +87,6 @@ class CORE_EXPORT RawResource final : public Resource {
return !isLinkPreload();
}
- bool willFollowRedirect(const ResourceRequest&,
- const ResourceResponse&) override;
void willNotFollowRedirect() override;
void responseReceived(const ResourceResponse&,
std::unique_ptr<WebDataConsumerHandle>) override;

Powered by Google App Engine
This is Rietveld 408576698