Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 263703003: Remove max space limits in tests. (Closed)

Created:
6 years, 7 months ago by Hannes Payer (out of office)
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Remove max space limits in tests. BUG= Committed: https://code.google.com/p/v8/source/detail?r=21104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M test/mjsunit/binary-op-newspace.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/math-floor-global.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/math-floor-local.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/define-property-gc.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/math-abs.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/math-floor-part1.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/math-floor-part2.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/math-floor-part3.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/math-floor-part4.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1708.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/regress/regress-99167.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-create-exception.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
Hi Michael, since we were running these tests without these limits for months (because we ...
6 years, 7 months ago (2014-04-30 19:32:06 UTC) #1
Hannes Payer (out of office)
Committed patchset #1 manually as r21104 (tree was closed).
6 years, 7 months ago (2014-04-30 19:33:09 UTC) #2
Jakob Kummerow
6 years, 7 months ago (2014-05-05 08:25:41 UTC) #3
Message was sent while issue was closed.
On 2014/04/30 19:32:06, Hannes Payer wrote:
> I cannot think about a reason why the limits make sense

--max-new-space-size makes sense when you want to ensure that even a relatively
short-running test triggers one or more allocation failures and resulting
scavenges. Especially for the regression tests, I would guess that the flag was
necessary to reproduce the original bug.
--max-old-space-size makes sense when a test tests OOM behavior, but it doesn't
look like any of the tests you modified did that, so it's probably fine to
remove that flag.

Powered by Google App Engine
This is Rietveld 408576698