Allow shared modules to whitelist extensions that import them.

extensions/common/manifest_handlers/shared_module_manifest_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/version.h"
 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest_handlers/shared_module_info.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 21 matching lines @@
   scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);
 
   EXPECT_TRUE(SharedModuleInfo::IsSharedModule(extension.get()))
       << manifest.name();
   EXPECT_FALSE(SharedModuleInfo::ImportsModules(extension.get()))
       << manifest.name();
   EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo"))
       << manifest.name();
   EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo/bar"))
       << manifest.name();
+
+  EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
+                  kImportId1)) << manifest.name();
+  EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
+                  kImportId2)) << manifest.name();
+  EXPECT_FALSE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
+                  kNoImport)) << manifest.name();
+}
+
+TEST_F(SharedModuleManifestTest, ExportWhitelistAll) {
+  Manifest manifest("shared_module_export_no_whitelist.json");
+
+  scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);
+
+  EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
+                  kImportId1)) << manifest.name();
+  EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
+                  kImportId2)) << manifest.name();
+  EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
+                  kNoImport)) << manifest.name();
 }
 
 TEST_F(SharedModuleManifestTest, ExportFoo) {
   Manifest manifest("shared_module_export_foo.json");
 
   scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);
 
   EXPECT_TRUE(SharedModuleInfo::IsSharedModule(extension.get()))
       << manifest.name();
   EXPECT_FALSE(SharedModuleInfo::ImportsModules(extension.get()))
       << manifest.name();
   EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo"))
       << manifest.name();
   EXPECT_FALSE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo/bar"))
       << manifest.name();
 }
 
 TEST_F(SharedModuleManifestTest, ExportParseErrors) {
   Testcase testcases[] = {
     Testcase("shared_module_export_and_import.json",
              "Simultaneous 'import' and 'export' are not allowed."),
     Testcase("shared_module_export_not_dict.json",
              "Invalid value for 'export'."),
     Testcase("shared_module_export_resources_not_list.json",
              "Invalid value for 'export.resources'."),
     Testcase("shared_module_export_resource_not_string.json",
              "Invalid value for 'export.resources[1]'."),
+    Testcase("shared_module_export_whitelist_item_not_id.json",
+             "Invalid value for 'export.whitelist[0]'."),
+    Testcase("shared_module_export_whitelist_item_not_string.json",
+             "Invalid value for 'export.whitelist[0]'."),
+    Testcase("shared_module_export_whitelist_not_list.json",
+             "Invalid value for 'export.whitelist'."),
   };
   RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
 }
 
 TEST_F(SharedModuleManifestTest, SharedModuleStaticFunctions) {
   EXPECT_TRUE(SharedModuleInfo::IsImportedPath(kValidImportPath));
   EXPECT_FALSE(SharedModuleInfo::IsImportedPath(kInvalidImportPath));
 
   std::string id;
   std::string relative;
@@ skipping 32 matching lines @@
              "Invalid value for 'import'."),
     Testcase("shared_module_import_invalid_id.json",
              "Invalid value for 'import[0].id'."),
     Testcase("shared_module_import_invalid_version.json",
              "Invalid value for 'import[0].minimum_version'."),
   };
   RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
 }
 
 }  // namespace extensions