Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2197)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/md_bookmarks/toolbar.js

Issue 2637023002: [MD Bookmarks] Add routing. (Closed)
Patch Set: First patch fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/md_bookmarks/store.js ('K') | « chrome/browser/resources/md_bookmarks/store.js ('k') | chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc » ('j') | chrome/test/data/webui/md_bookmarks/store_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_bookmarks/toolbar.js
diff --git a/chrome/browser/resources/md_bookmarks/toolbar.js b/chrome/browser/resources/md_bookmarks/toolbar.js
index bfce3d0d8f86bb4c8c9432a5d8be00d5d7cb5263..b47194d934dbbadb0f2869016ced42c543030602 100644
--- a/chrome/browser/resources/md_bookmarks/toolbar.js
+++ b/chrome/browser/resources/md_bookmarks/toolbar.js
@@ -69,7 +69,7 @@ Polymer({
/** @private */
onSearchTermChanged_: function() {
- if (!this.searchTerm)
- this.searchField.setValue('');
+ if (this.searchField.getValue() != this.searchTerm)
calamity 2017/01/18 03:37:21 What happens if you just remove this check...?
angelayang 2017/01/18 06:34:03 Oh yes it would be fine, i didn't realize that tha
+ this.searchField.setValue(this.searchTerm || '');
},
});
« chrome/browser/resources/md_bookmarks/store.js ('K') | « chrome/browser/resources/md_bookmarks/store.js ('k') | chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc » ('j') | chrome/test/data/webui/md_bookmarks/store_test.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698