Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7108)

Unified Diff: chrome/browser/resources/md_bookmarks/store.js

Issue 2637023002: [MD Bookmarks] Add routing. (Closed)
Patch Set: Reuse the existing searchTerm and selectedId handlers for query change events. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/store.js
diff --git a/chrome/browser/resources/md_bookmarks/store.js b/chrome/browser/resources/md_bookmarks/store.js
index baddea20b2e1979feb20095a57cae3ba320e3edd..83e945afa26021350a1618816e9a516eb6d03ffa 100644
--- a/chrome/browser/resources/md_bookmarks/store.js
+++ b/chrome/browser/resources/md_bookmarks/store.js
@@ -72,8 +72,8 @@ var BookmarksStore = Polymer({
chrome.bookmarks.onChanged.addListener(this.onBookmarkChanged_.bind(this));
},
-////////////////////////////////////////////////////////////////////////////////
-// bookmarks-store, private:
+ //////////////////////////////////////////////////////////////////////////////
+ // bookmarks-store, private:
/**
* @param {BookmarkTreeNode} rootNode
@@ -85,7 +85,13 @@ var BookmarksStore = Polymer({
this.rootNode.path = 'rootNode';
BookmarksStore.generatePaths(rootNode, 0);
BookmarksStore.initNodes(this.rootNode, this.idToNodeMap_);
- this.fire('selected-folder-changed', this.rootNode.children[0].id);
+
+ // Initialize the store's fields from the router.
+ if (this.$.router.searchTerm) {
tsergeant 2017/01/20 02:13:09 Remove {} here
angelayang 2017/01/20 03:44:37 Done.
+ this.searchTerm = this.$.router.searchTerm;
+ } else {
+ this.fire('selected-folder-changed', this.$.router.selectedId);
+ }
},
/** @private */
@@ -110,7 +116,7 @@ var BookmarksStore = Polymer({
/** @private */
updateSearchDisplay_: function() {
- if (this.searchTerm == '') {
+ if (!this.searchTerm) {
this.fire('selected-folder-changed', this.rootNode.children[0].id);
} else {
chrome.bookmarks.search(this.searchTerm, function(results) {
@@ -150,8 +156,8 @@ var BookmarksStore = Polymer({
delete this.idToNodeMap_[id];
},
-////////////////////////////////////////////////////////////////////////////////
-// bookmarks-store, bookmarks API event listeners:
+ //////////////////////////////////////////////////////////////////////////////
+ // bookmarks-store, bookmarks API event listeners:
/**
* Callback for when a bookmark node is removed.
@@ -191,8 +197,8 @@ var BookmarksStore = Polymer({
this.updateSearchDisplay_();
},
-////////////////////////////////////////////////////////////////////////////////
-// bookmarks-store, bookmarks app event listeners:
+ //////////////////////////////////////////////////////////////////////////////
+ // bookmarks-store, bookmarks app event listeners:
/**
* @param {Event} e
@@ -216,10 +222,14 @@ var BookmarksStore = Polymer({
if (this.selectedId)
this.set(this.idToNodeMap_[this.selectedId].path + '.isSelected', false);
- var selectedId = /** @type {string} */ (e.detail);
- var newFolder = this.idToNodeMap_[selectedId];
+ // Check if the selected id is that of a defined folder.
+ var id = /** @type {string} */ (e.detail);
+ if (!this.idToNodeMap_[id] || this.idToNodeMap_[id].url)
+ id = this.rootNode.children[0].id;
+
+ var newFolder = this.idToNodeMap_[id];
this.set(newFolder.path + '.isSelected', true);
- this.selectedId = selectedId;
+ this.selectedId = id;
},
/**

Powered by Google App Engine
This is Rietveld 408576698