Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: content/renderer/manifest/manifest_uma_util.cc

Issue 2637003002: Add share_target field to Manifest. (Closed)
Patch Set: Changed share_target type to base::Optional, and fixed tests, according to feedback. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/manifest/manifest_parser_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/manifest/manifest_uma_util.cc
diff --git a/content/renderer/manifest/manifest_uma_util.cc b/content/renderer/manifest/manifest_uma_util.cc
index 4a0a0f142eb8d4c071a589043991349930ce3562..a7ffd3f54dd966fb6c5e3b0c5dfe230aa8f6b83d 100644
--- a/content/renderer/manifest/manifest_uma_util.cc
+++ b/content/renderer/manifest/manifest_uma_util.cc
@@ -44,6 +44,8 @@ void ManifestUmaUtil::ParseSucceeded(const Manifest& manifest) {
UMA_HISTOGRAM_BOOLEAN("Manifest.HasProperty.orientation",
manifest.orientation != blink::WebScreenOrientationLockDefault);
UMA_HISTOGRAM_BOOLEAN("Manifest.HasProperty.icons", !manifest.icons.empty());
+ UMA_HISTOGRAM_BOOLEAN("Manifest.HasProperty.share_target",
+ manifest.share_target.has_value());
UMA_HISTOGRAM_BOOLEAN("Manifest.HasProperty.gcm_sender_id",
!manifest.gcm_sender_id.is_null());
}
« no previous file with comments | « content/renderer/manifest/manifest_parser_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698