content/renderer/manifest/manifest_uma_util.cc - Issue 2637003002: Add share_target field to Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/manifest/manifest_uma_util.cc

Issue 2637003002: Add share_target field to Manifest. (Closed)

Patch Set: Doc update and clean up Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/manifest/manifest_uma_util.cc

diff --git a/content/renderer/manifest/manifest_uma_util.cc b/content/renderer/manifest/manifest_uma_util.cc

index 4a0a0f142eb8d4c071a589043991349930ce3562..f2103cdda44e860cea16d31b6df7994a8f6c450c 100644

--- a/content/renderer/manifest/manifest_uma_util.cc

+++ b/content/renderer/manifest/manifest_uma_util.cc

@@ -44,6 +44,8 @@ void ManifestUmaUtil::ParseSucceeded(const Manifest& manifest) {

UMA_HISTOGRAM_BOOLEAN("Manifest.HasProperty.orientation",

manifest.orientation != blink::WebScreenOrientationLockDefault);

UMA_HISTOGRAM_BOOLEAN("Manifest.HasProperty.icons", !manifest.icons.empty());

+ UMA_HISTOGRAM_BOOLEAN("Manifest.HasProperty.share_target",

+ !manifest.share_target.is_null());

UMA_HISTOGRAM_BOOLEAN("Manifest.HasProperty.gcm_sender_id",

!manifest.gcm_sender_id.is_null());

}