Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: content/common/manifest_manager_messages.h

Issue 2637003002: Add share_target field to Manifest. (Closed)
Patch Set: Changed share_target type to base::Optional, and fixed tests, according to feedback. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/public/common/manifest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for the web manifest manager. 5 // IPC messages for the web manifest manager.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 #include "content/public/common/manifest.h" 9 #include "content/public/common/manifest.h"
10 #include "ipc/ipc_message_macros.h" 10 #include "ipc/ipc_message_macros.h"
11 11
12 #undef IPC_MESSAGE_EXPORT 12 #undef IPC_MESSAGE_EXPORT
13 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT 13 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT
14 14
15 #define IPC_MESSAGE_START ManifestManagerMsgStart 15 #define IPC_MESSAGE_START ManifestManagerMsgStart
16 16
17 IPC_STRUCT_TRAITS_BEGIN(content::Manifest::Icon) 17 IPC_STRUCT_TRAITS_BEGIN(content::Manifest::Icon)
18 IPC_STRUCT_TRAITS_MEMBER(src) 18 IPC_STRUCT_TRAITS_MEMBER(src)
19 IPC_STRUCT_TRAITS_MEMBER(type) 19 IPC_STRUCT_TRAITS_MEMBER(type)
20 IPC_STRUCT_TRAITS_MEMBER(sizes) 20 IPC_STRUCT_TRAITS_MEMBER(sizes)
21 IPC_STRUCT_TRAITS_END() 21 IPC_STRUCT_TRAITS_END()
22 22
23 IPC_STRUCT_TRAITS_BEGIN(content::Manifest::ShareTarget)
24 IPC_STRUCT_TRAITS_MEMBER(url_template)
25 IPC_STRUCT_TRAITS_END()
26
23 IPC_STRUCT_TRAITS_BEGIN(content::Manifest::RelatedApplication) 27 IPC_STRUCT_TRAITS_BEGIN(content::Manifest::RelatedApplication)
24 IPC_STRUCT_TRAITS_MEMBER(platform) 28 IPC_STRUCT_TRAITS_MEMBER(platform)
25 IPC_STRUCT_TRAITS_MEMBER(url) 29 IPC_STRUCT_TRAITS_MEMBER(url)
26 IPC_STRUCT_TRAITS_MEMBER(id) 30 IPC_STRUCT_TRAITS_MEMBER(id)
27 IPC_STRUCT_TRAITS_END() 31 IPC_STRUCT_TRAITS_END()
28 32
29 IPC_STRUCT_TRAITS_BEGIN(content::Manifest) 33 IPC_STRUCT_TRAITS_BEGIN(content::Manifest)
30 IPC_STRUCT_TRAITS_MEMBER(name) 34 IPC_STRUCT_TRAITS_MEMBER(name)
31 IPC_STRUCT_TRAITS_MEMBER(short_name) 35 IPC_STRUCT_TRAITS_MEMBER(short_name)
32 IPC_STRUCT_TRAITS_MEMBER(start_url) 36 IPC_STRUCT_TRAITS_MEMBER(start_url)
33 IPC_STRUCT_TRAITS_MEMBER(scope) 37 IPC_STRUCT_TRAITS_MEMBER(scope)
34 IPC_STRUCT_TRAITS_MEMBER(display) 38 IPC_STRUCT_TRAITS_MEMBER(display)
35 IPC_STRUCT_TRAITS_MEMBER(orientation) 39 IPC_STRUCT_TRAITS_MEMBER(orientation)
36 IPC_STRUCT_TRAITS_MEMBER(icons) 40 IPC_STRUCT_TRAITS_MEMBER(icons)
41 IPC_STRUCT_TRAITS_MEMBER(share_target)
37 IPC_STRUCT_TRAITS_MEMBER(related_applications) 42 IPC_STRUCT_TRAITS_MEMBER(related_applications)
38 IPC_STRUCT_TRAITS_MEMBER(prefer_related_applications) 43 IPC_STRUCT_TRAITS_MEMBER(prefer_related_applications)
39 IPC_STRUCT_TRAITS_MEMBER(theme_color) 44 IPC_STRUCT_TRAITS_MEMBER(theme_color)
40 IPC_STRUCT_TRAITS_MEMBER(background_color) 45 IPC_STRUCT_TRAITS_MEMBER(background_color)
41 IPC_STRUCT_TRAITS_MEMBER(gcm_sender_id) 46 IPC_STRUCT_TRAITS_MEMBER(gcm_sender_id)
42 IPC_STRUCT_TRAITS_END() 47 IPC_STRUCT_TRAITS_END()
43 48
44 // The browser process requests for the manifest linked with the associated 49 // The browser process requests for the manifest linked with the associated
45 // RenderFrame. The render process will respond via a RequestManifestResponse 50 // RenderFrame. The render process will respond via a RequestManifestResponse
46 // IPC message with a Manifest object attached to it and the associated 51 // IPC message with a Manifest object attached to it and the associated
47 // |request_id| that was initially given. 52 // |request_id| that was initially given.
48 IPC_MESSAGE_ROUTED1(ManifestManagerMsg_RequestManifest, 53 IPC_MESSAGE_ROUTED1(ManifestManagerMsg_RequestManifest,
49 int /* request_id */) 54 int /* request_id */)
50 55
51 // The render process' response to a RequestManifest. The |request_id| will 56 // The render process' response to a RequestManifest. The |request_id| will
52 // match the one that was initially received. |manifest_url| will be empty if 57 // match the one that was initially received. |manifest_url| will be empty if
53 // there is no manifest specified in the associated RenderFrame's document. 58 // there is no manifest specified in the associated RenderFrame's document.
54 // |manifest| will be empty if a manifest was specified, but could not be 59 // |manifest| will be empty if a manifest was specified, but could not be
55 // parsed correctly. 60 // parsed correctly.
56 IPC_MESSAGE_ROUTED3(ManifestManagerHostMsg_RequestManifestResponse, 61 IPC_MESSAGE_ROUTED3(ManifestManagerHostMsg_RequestManifestResponse,
57 int, /* request_id */ 62 int, /* request_id */
58 GURL, /* manifest URL */ 63 GURL, /* manifest URL */
59 content::Manifest /* manifest */) 64 content::Manifest /* manifest */)
OLDNEW
« no previous file with comments | « no previous file | content/public/common/manifest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698