Add share_target field to Manifest.

content/public/common/manifest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/manifest.h"
 
 namespace content {
 
 // We need to provide a value here which is out of the range of a 32-bit integer
 // since otherwise we would not be able to check whether a theme color was valid
 // or not. The simplest way to do this is to simply add one to the maximum
 // possible 32-bit integer.
 const int64_t Manifest::kInvalidOrMissingColor =
     static_cast<int64_t>(std::numeric_limits<int32_t>::max()) + 1;
 const size_t Manifest::kMaxIPCStringLength = 4 * 1024;
 
 Manifest::Icon::Icon() { }
 
 Manifest::Icon::Icon(const Icon& other) = default;
 
-Manifest::Icon::~Icon() {
-}
+Manifest::Icon::~Icon() { }
 
 bool Manifest::Icon::operator==(const Manifest::Icon& other) const {
   return src == other.src && type == other.type && sizes == other.sizes;
 }
 
-Manifest::RelatedApplication::RelatedApplication() {
+Manifest::ShareTarget::ShareTarget() { }

[Matt Giuca, 2017/01/18 07:51:32]

Has this been git cl formatted? I think there's supposed to be no space in
between these.

[constantina, 2017/01/18 23:28:09]

Done. There were inconsistencies, so I made all empty methods follow the first
formatting, which happened to have a space. Git cl formatted, and also corrected
the first.

+
+Manifest::ShareTarget::~ShareTarget() { }
+
+bool Manifest::ShareTarget::is_null() const {
+  return url_template.is_null();
 }
 
-Manifest::RelatedApplication::~RelatedApplication() {
-}
+Manifest::RelatedApplication::RelatedApplication() { }
+
+Manifest::RelatedApplication::~RelatedApplication() { }
 
 Manifest::Manifest()
     : display(blink::WebDisplayModeUndefined),
       orientation(blink::WebScreenOrientationLockDefault),
       prefer_related_applications(false),
       theme_color(Manifest::kInvalidOrMissingColor),
       background_color(Manifest::kInvalidOrMissingColor) {
 }
 
 Manifest::Manifest(const Manifest& other) = default;
 
-Manifest::~Manifest() {
-}
+Manifest::~Manifest() { }
 
 bool Manifest::IsEmpty() const {
   return name.is_null() &&
          short_name.is_null() &&
          start_url.is_empty() &&
          display == blink::WebDisplayModeUndefined &&
          orientation == blink::WebScreenOrientationLockDefault &&
          icons.empty() &&
+         share_target.is_null() &&
          related_applications.empty() &&
          !prefer_related_applications &&
          theme_color == Manifest::kInvalidOrMissingColor &&
          background_color == Manifest::kInvalidOrMissingColor &&
          gcm_sender_id.is_null() &&
          scope.is_empty();
 }
 
 } // namespace content