Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: src/debug/liveedit.h

Issue 2636913002: [liveedit] reimplement frame restarting. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/ia32/debug-ia32.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/liveedit.h
diff --git a/src/debug/liveedit.h b/src/debug/liveedit.h
index be70d2e50c6a16e58d4d87151a7c7241b1094798..892c0690e28a7d247f41c1983f5b9e3c4825bcde 100644
--- a/src/debug/liveedit.h
+++ b/src/debug/liveedit.h
@@ -74,8 +74,6 @@ class LiveEdit : AllStatic {
public:
static void InitializeThreadLocal(Debug* debug);
- static bool SetAfterBreakTarget(Debug* debug);
-
MUST_USE_RESULT static MaybeHandle<JSArray> GatherCompileInfo(
Handle<Script> script,
Handle<String> source);
@@ -146,40 +144,6 @@ class LiveEdit : AllStatic {
// Architecture-specific constant.
static const bool kFrameDropperSupported;
-
- /**
- * Defines layout of a stack frame that supports padding. This is a regular
- * internal frame that has a flexible stack structure. LiveEdit can shift
- * its lower part up the stack, taking up the 'padding' space when additional
- * stack memory is required.
- * Such frame is expected immediately above the topmost JavaScript frame.
- *
- * Stack Layout:
- * --- Top
- * LiveEdit routine frames
- * ---
- * C frames of debug handler
- * ---
- * ...
- * ---
- * An internal frame that has n padding words:
- * - any number of words as needed by code -- upper part of frame
- * - padding size: a Smi storing n -- current size of padding
- * - padding: n words filled with kPaddingValue in form of Smi
- * - 3 context/type words of a regular InternalFrame
- * - fp
- * ---
- * Topmost JavaScript frame
- * ---
- * ...
- * --- Bottom
- */
- // A number of words that should be reserved on stack for the LiveEdit use.
- // Stored on stack in form of Smi.
- static const int kFramePaddingInitialSize = 1;
- // A value that padding words are filled with (in form of Smi). Going
- // bottom-top, the first word not having this value is a counter word.
- static const int kFramePaddingValue = kFramePaddingInitialSize + 1;
};
« no previous file with comments | « src/debug/ia32/debug-ia32.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698