Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: src/isolate.cc

Issue 2636903002: Assert that context creation doesn't throw (Closed)
Patch Set: updates Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | test/cctest/test-thread-termination.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 0c0af8472a75f3067d63c17f662b2639d78edd85..fa68e8c0441bdd1868c3223c40e2b8097580d571 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1693,6 +1693,8 @@ bool Isolate::IsExternalHandlerOnTop(Object* exception) {
void Isolate::ReportPendingMessages() {
+ DCHECK(AllowExceptions::IsAllowed(this));
+
Object* exception = pending_exception();
// Try to propagate the exception to an external v8::TryCatch handler. If
@@ -3308,8 +3310,9 @@ void Isolate::PromiseReactionJob(Handle<PromiseReactionJobInfo> info,
handle(deferred_promise_arr->get(i), this),
handle(deferred_on_resolve_arr->get(i), this),
handle(deferred_on_reject_arr->get(i), this)};
- *result = Execution::TryCall(this, promise_handle_fn, undefined,
- arraysize(argv), argv, maybe_exception);
+ *result = Execution::TryCall(
+ this, promise_handle_fn, undefined, arraysize(argv), argv,
+ Execution::MessageHandling::kReport, maybe_exception);
// If execution is terminating, just bail out.
if (result->is_null() && maybe_exception->is_null()) {
return;
@@ -3319,8 +3322,9 @@ void Isolate::PromiseReactionJob(Handle<PromiseReactionJobInfo> info,
Handle<Object> argv[] = {value, tasks, deferred_promise,
handle(info->deferred_on_resolve(), this),
handle(info->deferred_on_reject(), this)};
- *result = Execution::TryCall(this, promise_handle_fn, undefined,
- arraysize(argv), argv, maybe_exception);
+ *result = Execution::TryCall(
+ this, promise_handle_fn, undefined, arraysize(argv), argv,
+ Execution::MessageHandling::kReport, maybe_exception);
}
}
@@ -3334,16 +3338,17 @@ void Isolate::PromiseResolveThenableJob(
Handle<JSFunction> reject(info->reject(), this);
Handle<JSReceiver> then(info->then(), this);
Handle<Object> argv[] = {resolve, reject};
- *result = Execution::TryCall(this, then, thenable, arraysize(argv), argv,
- maybe_exception);
+ *result =
+ Execution::TryCall(this, then, thenable, arraysize(argv), argv,
+ Execution::MessageHandling::kReport, maybe_exception);
Handle<Object> reason;
if (maybe_exception->ToHandle(&reason)) {
DCHECK(result->is_null());
Handle<Object> reason_arg[] = {reason};
- *result =
- Execution::TryCall(this, reject, factory()->undefined_value(),
- arraysize(reason_arg), reason_arg, maybe_exception);
+ *result = Execution::TryCall(
+ this, reject, factory()->undefined_value(), arraysize(reason_arg),
+ reason_arg, Execution::MessageHandling::kReport, maybe_exception);
}
}
@@ -3423,9 +3428,9 @@ void Isolate::RunMicrotasksInternal() {
if (microtask->IsJSFunction()) {
Handle<JSFunction> microtask_function =
Handle<JSFunction>::cast(microtask);
- result = Execution::TryCall(this, microtask_function,
- factory()->undefined_value(), 0, NULL,
- &maybe_exception);
+ result = Execution::TryCall(
+ this, microtask_function, factory()->undefined_value(), 0,
+ nullptr, Execution::MessageHandling::kReport, &maybe_exception);
} else if (microtask->IsPromiseResolveThenableJobInfo()) {
PromiseResolveThenableJob(
Handle<PromiseResolveThenableJobInfo>::cast(microtask), &result,
« no previous file with comments | « src/heap/heap.cc ('k') | test/cctest/test-thread-termination.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698