Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 263683002: Set file tokens for NaCl main nexe if available to enable validation caching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: concat filepath literal Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/browser/nacl_browser.cc ('k') | ppapi/api/private/ppb_nacl_private.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/ppb_nacl_private_impl.cc
diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc
index 634bb81b1428b8f5480d4072a7bff91d10d65d93..3e4304ea287bd593708db6e4e218bd0a607fcb8a 100644
--- a/components/nacl/renderer/ppb_nacl_private_impl.cc
+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc
@@ -1326,6 +1326,8 @@ void DownloadNexeCompletion(const DownloadNexeRequest& request,
void DownloadNexe(PP_Instance instance,
const char* url,
PP_FileHandle* out_handle,
+ uint64_t* file_token_lo,
+ uint64_t* file_token_hi,
PP_CompletionCallback callback) {
CHECK(url);
CHECK(out_handle);
@@ -1336,12 +1338,10 @@ void DownloadNexe(PP_Instance instance,
request.start_time = base::Time::Now();
// Try the fast path for retrieving the file first.
- uint64_t file_token_lo = 0;
- uint64_t file_token_hi = 0;
PP_FileHandle file_handle = OpenNaClExecutable(instance,
url,
- &file_token_lo,
- &file_token_hi);
+ file_token_lo,
+ file_token_hi);
if (file_handle != PP_kInvalidFileHandle) {
DownloadNexeCompletion(request,
file_handle,
« no previous file with comments | « components/nacl/browser/nacl_browser.cc ('k') | ppapi/api/private/ppb_nacl_private.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698