Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 263663002: Map::Normalize() introduced as single entry point for map normalization and Map::NotifyLeafMapLayou… (Closed)

Created:
6 years, 7 months ago by Igor Sheludko
Modified:
6 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Map::Normalize() introduced as single entry point for map normalization and Map::NotifyLeafMapLayoutChange() made private. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21117

Patch Set 1 #

Patch Set 2 : Addressing review notes #

Total comments: 2

Patch Set 3 : Addressing review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -66 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 5 chunks +24 lines, -13 lines 0 comments Download
M src/objects.cc View 1 2 5 chunks +65 lines, -46 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Igor Sheludko
PTAL
6 years, 7 months ago (2014-04-30 13:36:45 UTC) #1
Igor Sheludko
Addressed offline comments.
6 years, 7 months ago (2014-04-30 15:50:23 UTC) #2
Toon Verwaest
lgtm with comment https://codereview.chromium.org/263663002/diff/40001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/263663002/diff/40001/src/objects.cc#newcode7222 src/objects.cc:7222: new_map->EquivalentToForNormalization(*fast_map, mode)) { Seems like EquivalentToForNormalization ...
6 years, 7 months ago (2014-05-01 11:24:34 UTC) #3
Igor Sheludko
https://codereview.chromium.org/263663002/diff/40001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/263663002/diff/40001/src/objects.cc#newcode7222 src/objects.cc:7222: new_map->EquivalentToForNormalization(*fast_map, mode)) { On 2014/05/01 11:24:34, Toon Verwaest wrote: ...
6 years, 7 months ago (2014-05-02 09:47:38 UTC) #4
Igor Sheludko
6 years, 7 months ago (2014-05-02 10:27:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r21117 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698