Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: base/debug/traced_value.h

Issue 263653002: Move traced_value.* from cc/debug/ to base/debug/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added BASE_EXPORT Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gypi ('k') | base/debug/traced_value.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/traced_value.h
diff --git a/cc/debug/traced_value.h b/base/debug/traced_value.h
similarity index 61%
rename from cc/debug/traced_value.h
rename to base/debug/traced_value.h
index e96c09a58963eb69cbcff4c51d6df61fe572c4c1..dd5a466c210a5efcbefa86fba462109e33e91fb5 100644
--- a/cc/debug/traced_value.h
+++ b/base/debug/traced_value.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CC_DEBUG_TRACED_VALUE_H_
-#define CC_DEBUG_TRACED_VALUE_H_
+#ifndef BASE_DEBUG_TRACED_VALUE_H_
+#define BASE_DEBUG_TRACED_VALUE_H_
#include <string>
@@ -13,14 +13,17 @@
namespace base {
class DictionaryValue;
class Value;
-}
-namespace cc {
+namespace debug {
-class TracedValue : public base::debug::ConvertableToTraceFormat {
+// This class is used to convert base::Value to a ConvertableToTraceFormat
+// object. It allows to build the argument value at the point of instrumenation
+// and postpone costly part of its serialization until the tracing is stopped.
+class BASE_EXPORT TracedValue : public base::debug::ConvertableToTraceFormat {
public:
static scoped_ptr<base::Value> CreateIDRef(const void* id);
- static void MakeDictIntoImplicitSnapshot(
- base::DictionaryValue* dict, const char* object_name, const void* id);
+ static void MakeDictIntoImplicitSnapshot(base::DictionaryValue* dict,
+ const char* object_name,
+ const void* id);
static void MakeDictIntoImplicitSnapshotWithCategory(
const char* category,
base::DictionaryValue* dict,
@@ -46,6 +49,7 @@ class TracedValue : public base::debug::ConvertableToTraceFormat {
DISALLOW_COPY_AND_ASSIGN(TracedValue);
};
-} // namespace cc
+} // namespace debug
+} // namespace base
-#endif // CC_DEBUG_TRACED_VALUE_H_
+#endif // BASE_DEBUG_TRACED_VALUE_H_
« no previous file with comments | « base/base.gypi ('k') | base/debug/traced_value.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698