Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2636483002: Add MSA optimized NV12/21 To RGB row functions (Closed)

Created:
3 years, 11 months ago by manojkumar.bhosale
Modified:
3 years, 11 months ago
Reviewers:
fbarchard1
CC:
gordana.cmiljanovic_imgtec.com, raghu.gandham_imgtec.com, parag.salasakar_imgtec.com, mandar.sahastrabuddhe_imgtec.com, rob.isherwood_imgtec.com
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add MSA optimized NV12/21 To RGB row functions R=fbarchard@google.com BUG=libyuv:634 Performance Gain (vs C auto-vectorized) NV12ToARGBRow_MSA - ~1.5x NV12ToARGBRow_Any_MSA - ~1.4x NV12ToRGB565Row_MSA - ~1.4x NV12ToRGB565Row_Any_MSA - ~1.4x NV21ToARGBRow_MSA - ~1.5x NV21ToARGBRow_Any_MSA - ~1.5x SobelRow_MSA - ~4.3x SobelRow_Any_MSA - ~3.4x SobelToPlaneRow_MSA - ~8.0x SobelToPlaneRow_Any_MSA - ~4.7x SobelXYRow_MSA - ~3.0x SobelXYRow_Any_MSA - ~2.5x Performance Gain (vs C non-vectorized) NV12ToARGBRow_MSA - ~6.5x NV12ToARGBRow_Any_MSA - ~6.5x NV12ToRGB565Row_MSA - ~6.2x NV12ToRGB565Row_Any_MSA - ~6.1x NV21ToARGBRow_MSA - ~6.5x NV21ToARGBRow_Any_MSA - ~6.5x SobelRow_MSA - ~14.5x SobelRow_Any_MSA - ~11.3x SobelToPlaneRow_MSA - ~34.2x SobelToPlaneRow_Any_MSA - ~19.4x SobelXYRow_MSA - ~11.1x SobelXYRow_Any_MSA - ~9.1x Committed: https://chromium.googlesource.com/libyuv/libyuv/+/09b8c971b305ed99a18e416df0845e23bf702565

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporated review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -78 lines) Patch
M include/libyuv/row.h View 9 chunks +60 lines, -0 lines 0 comments Download
M source/convert_argb.cc View 3 chunks +24 lines, -0 lines 0 comments Download
M source/planar_functions.cc View 4 chunks +32 lines, -0 lines 0 comments Download
M source/row_any.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M source/row_msa.cc View 1 11 chunks +295 lines, -78 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
manojkumar.bhosale
3 years, 11 months ago (2017-01-13 11:43:39 UTC) #1
manojkumar.bhosale
Updated with reviewers, cc list and performance gain numbers
3 years, 11 months ago (2017-01-13 11:46:03 UTC) #3
fbarchard1
lgtm https://codereview.chromium.org/2636483002/diff/1/source/row_msa.cc File source/row_msa.cc (right): https://codereview.chromium.org/2636483002/diff/1/source/row_msa.cc#newcode2061 source/row_msa.cc:2061: reg3 = (v4i32)__msa_ilvl_h((v8i16)zero, (v8i16)vec1); consider macros to read ...
3 years, 11 months ago (2017-01-13 18:46:01 UTC) #4
manojkumar.bhosale
https://codereview.chromium.org/2636483002/diff/1/source/row_msa.cc File source/row_msa.cc (right): https://codereview.chromium.org/2636483002/diff/1/source/row_msa.cc#newcode2061 source/row_msa.cc:2061: reg3 = (v4i32)__msa_ilvl_h((v8i16)zero, (v8i16)vec1); On 2017/01/13 18:46:01, fbarchard1 wrote: ...
3 years, 11 months ago (2017-01-17 10:29:45 UTC) #5
manojkumar.bhosale
Incorporated review comments
3 years, 11 months ago (2017-01-17 11:41:00 UTC) #6
fbarchard1
lgtm
3 years, 11 months ago (2017-01-17 19:34:05 UTC) #7
manojkumar.bhosale
3 years, 11 months ago (2017-01-18 03:52:37 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
09b8c971b305ed99a18e416df0845e23bf702565 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698