Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3322)

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_button_controller.h

Issue 2636473003: [Mac] Update the Text Color for the Avatar Button (Closed)
Patch Set: Fix for shrike Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/avatar_button_controller.h
diff --git a/chrome/browser/ui/cocoa/profiles/avatar_button_controller.h b/chrome/browser/ui/cocoa/profiles/avatar_button_controller.h
index 51a349ef96a09115321daabaa41953c556b3aa34..bf4e6cf6b6902f65b428a2e068eaf1ec9ea22a39 100644
--- a/chrome/browser/ui/cocoa/profiles/avatar_button_controller.h
+++ b/chrome/browser/ui/cocoa/profiles/avatar_button_controller.h
@@ -20,9 +20,12 @@ class Browser;
// Whether the signed in profile has an authentication error. Used to
// display an error icon next to the button text.
BOOL hasError_;
+
+ // The window associated with the avatar button. Weak.
+ NSWindow* window_;
}
// Designated initializer.
-- (id)initWithBrowser:(Browser*)browser;
+- (id)initWithBrowser:(Browser*)browser window:(NSWindow*)window;
Robert Sesek 2017/01/27 11:01:28 Is |window| always the same as browser->window()->
spqchan 2017/01/27 18:24:49 No, browser->window()->GetNativeWindow() is null
Robert Sesek 2017/01/30 16:54:10 Hmm. I don't understand why. From my reading of Br
// Overridden so that we can change the active state of the avatar button.
- (void)showAvatarBubbleAnchoredAt:(NSView*)anchor
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698