Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: runtime/vm/service.cc

Issue 2636443004: Make rewind work on DBC (Closed)
Patch Set: Tweaks Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service.h" 5 #include "vm/service.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "include/dart_native_api.h" 8 #include "include/dart_native_api.h"
9 #include "platform/globals.h" 9 #include "platform/globals.h"
10 10
(...skipping 3023 matching lines...) Expand 10 before | Expand all | Expand 10 after
3034 new UIntParameter("frameIndex", false), NULL, 3034 new UIntParameter("frameIndex", false), NULL,
3035 }; 3035 };
3036 3036
3037 3037
3038 static bool Resume(Thread* thread, JSONStream* js) { 3038 static bool Resume(Thread* thread, JSONStream* js) {
3039 const char* step_param = js->LookupParam("step"); 3039 const char* step_param = js->LookupParam("step");
3040 Debugger::ResumeAction step = Debugger::kContinue; 3040 Debugger::ResumeAction step = Debugger::kContinue;
3041 if (step_param != NULL) { 3041 if (step_param != NULL) {
3042 step = EnumMapper(step_param, step_enum_names, step_enum_values); 3042 step = EnumMapper(step_param, step_enum_names, step_enum_values);
3043 } 3043 }
3044 #if defined(TARGET_ARCH_DBC)
3045 if (step == Debugger::kStepRewind) {
3046 js->PrintError(kCannotResume,
3047 "Rewind not yet implemented on this architecture");
3048 return true;
3049 }
3050 #endif
3051 intptr_t frame_index = 1; 3044 intptr_t frame_index = 1;
3052 const char* frame_index_param = js->LookupParam("frameIndex"); 3045 const char* frame_index_param = js->LookupParam("frameIndex");
3053 if (frame_index_param != NULL) { 3046 if (frame_index_param != NULL) {
3054 if (step != Debugger::kStepRewind) { 3047 if (step != Debugger::kStepRewind) {
3055 // Only rewind supports the frameIndex parameter. 3048 // Only rewind supports the frameIndex parameter.
3056 js->PrintError( 3049 js->PrintError(
3057 kInvalidParams, 3050 kInvalidParams,
3058 "%s: the 'frameIndex' parameter can only be used when rewinding", 3051 "%s: the 'frameIndex' parameter can only be used when rewinding",
3059 js->method()); 3052 js->method());
3060 return true; 3053 return true;
(...skipping 1114 matching lines...) Expand 10 before | Expand all | Expand 10 after
4175 if (strcmp(method_name, method.name) == 0) { 4168 if (strcmp(method_name, method.name) == 0) {
4176 return &method; 4169 return &method;
4177 } 4170 }
4178 } 4171 }
4179 return NULL; 4172 return NULL;
4180 } 4173 }
4181 4174
4182 #endif // !PRODUCT 4175 #endif // !PRODUCT
4183 4176
4184 } // namespace dart 4177 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698