Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h

Issue 2636353002: [LayoutNG] Remove the state machine from ng_out_of_flow_layout_part. (Closed)
Patch Set: rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
index 72ca485312fec238711da38e82b32b4f5f8d5500..0391cb1b74a359437ac3d93c94f7772c488d17cf 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h
@@ -55,23 +55,22 @@ class CORE_EXPORT NGFragmentBuilder final
// Part 2: layout algorithm positions out-of-flow descendants.
//
// builder->SetInlineSize/SetBlockSize
- // builder->GetAndClearOutOfFlowDescendantCandidates(oof_candidates)
+ // builder->GetAndClearOutOfFlowDescendantCandidates(oof_candidates);
// NGOutOfFlowLayoutPart out_of_flow_layout(container_style,
// builder->Size());
// while (oof_candidates.size() > 0)
// {
- // candidate = oof_candidates.shift()
- // if (out_of_flow_layout.StartLayout(candidate))
+ // candidate = oof_candidates.shift();
+ // if (IsContainingBlockForAbsoluteChild(style, candidate_style)) {
// NGFragmentBase* fragment;
// NGLogicalOffset* fragment_offset;
- // while (out_of_flow_layout.Layout(&fragment, &fragment_offset) ==
- // kNotFinished)
- // ;
+ // out_of_flow_layout.Layout(candidate, &fragment, &offset);
// builder->AddChild(fragment);
- // builder->GetAndClearOutOfFlowDescendantCandidates(child_oof_candidates)
- // oof_candidates.prepend(child_oof_candidates)
- // else
+ // builder->GetAndClearOutOfFlowDescendantCandidates(child_oof_candidates);
+ // oof_candidates.prepend(child_oof_candidates);
+ // } else {
// builder->AddOutOfFlowDescendant();
+ // }
// }
NGFragmentBuilder& AddOutOfFlowChildCandidate(NGBlockNode*, NGLogicalOffset);

Powered by Google App Engine
This is Rietveld 408576698