Issue 263633003: [fsp] Make thread checks consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263633003: [fsp] Make thread checks consistent. (Closed)

Created:
6 years, 7 months ago by mtomasz

Modified:
6 years, 7 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[fsp] Make thread checks consistent. This patch replaces the old-style check to the new DCHECK_CURRENTLY_ON macro for consistency. TEST=Refactoring only. Current tests. BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267782

Patch Set 1 #

Patch Set 2 : Fixed. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -23 lines)			Patch
M	chrome/browser/chromeos/file_system_provider/fileapi/backend_delegate.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc	View	1	14 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/file_system_provider/service.cc	View		7 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/263633003/10001

6 years, 7 months ago (2014-05-01 23:20:02 UTC) #4

Message was sent while issue was closed.

Change committed as 267782

Expand Messages | Collapse Messages