Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2636313002: Throw TypeError on arg mismatch (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Throw TypeError on arg mismatch Improvement on #28286 - this is still not quite right as we'll throw a TypeError instead of a NSM in certain cases depending on the order. The spec will only throw a TypeError if NSM doesn't apply. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/c83dac537f98d0998513456960a4005f4910b4d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 11 months ago (2017-01-17 22:58:09 UTC) #3
Leaf
lgtm
3 years, 11 months ago (2017-01-17 23:51:30 UTC) #4
vsm
3 years, 11 months ago (2017-01-18 00:26:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c83dac537f98d0998513456960a4005f4910b4d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698