[Chromecast] Add support for z-order and window focus.

chromecast/graphics/cast_window_manager_aura_test.cc

Index: chromecast/graphics/cast_window_manager_aura_test.cc
diff --git a/chromecast/graphics/cast_window_manager_aura_test.cc b/chromecast/graphics/cast_window_manager_aura_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b42a0fe544dd3dbe83856f2e228cbb575a2eb536
--- /dev/null
+++ b/chromecast/graphics/cast_window_manager_aura_test.cc
@@ -0,0 +1,111 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromecast/graphics/cast_window_manager.h"
+
+#include <memory>
+
+#include "base/run_loop.h"
+#include "ui/aura/client/focus_client.h"
+#include "ui/aura/test/aura_test_base.h"
+#include "ui/aura/test/test_window_delegate.h"
+#include "ui/aura/test/ui_controls_factory_aura.h"
+#include "ui/aura/window.h"
+
+namespace chromecast {
+namespace test {
+
+using CastWindowManagerAuraTest = aura::test::AuraTestBase;
+
+class CastTestWindowDelegate : public aura::test::TestWindowDelegate {
+ public:
+  CastTestWindowDelegate() : key_code_(ui::VKEY_UNKNOWN) {}
+  ~CastTestWindowDelegate() override {}
+
+  // Overridden from TestWindowDelegate:
+  void OnKeyEvent(ui::KeyEvent* event) override {
+    key_code_ = event->key_code();
+  }
+
+  ui::KeyboardCode key_code() { return key_code_; }
+
+ private:
+  ui::KeyboardCode key_code_;
+
+  DISALLOW_COPY_AND_ASSIGN(CastTestWindowDelegate);
+};
+
+TEST_F(CastWindowManagerAuraTest, WindowInput) {
+  std::unique_ptr<CastWindowManager> window_manager(
+      CastWindowManager::Create(true /* enable input */));
+
+  CastTestWindowDelegate* window_delegate = new CastTestWindowDelegate();
+  std::unique_ptr<aura::Window> window(new aura::Window(window_delegate));
+  window->Init(ui::LAYER_NOT_DRAWN);
+  window->SetName("event window");
+  window_manager->AddWindow(window.get());
+  window->SetBounds(gfx::Rect(0, 0, 1280, 720));
+  window->Show();
+  EXPECT_FALSE(window->IsRootWindow());
+  EXPECT_TRUE(window->GetHost());
+
+  // Confirm that the Aura focus client tracks window focus correctly.
+  aura::client::FocusClient* focus_client =
+      aura::client::GetFocusClient(window.get());
+  EXPECT_TRUE(focus_client);
+  EXPECT_FALSE(focus_client->GetFocusedWindow());
+  window->Focus();
+  EXPECT_EQ(window.get(), focus_client->GetFocusedWindow());
+
+  // Confirm that a keyboard event is delivered to the window.
+  std::unique_ptr<ui_controls::UIControlsAura> event_generator(
+      aura::test::CreateUIControlsAura(window->GetHost()));
+  EXPECT_TRUE(event_generator->SendKeyPress(nullptr, ui::VKEY_0, false, false,
+                                            false, false));
+  base::RunLoop().RunUntilIdle();

[sadrul, 2017/01/26 01:50:10]

Do you need to spin the message-loop here?

[Joshua LeVasseur, 2017/01/26 02:51:01]

The event-dispatch logic posts tasks, so this is necessary (as far as I can
tell).  If I remove it, the unit test will fail with tasks left over on the run
queue.

[sadrul, 2017/01/27 00:30:56]

Ohh, you are using UIControlsAura. That's why.

Please switch to use ui::test::EventGenerator[1] instead. That is much simpler,
and does not need to cycle message-loop.

1:
https://cs.chromium.org/chromium/src/ui/events/test/event_generator.h?sq=pack...

[Joshua LeVasseur, 2017/01/27 04:53:44]

Thanks!  Done.

+  EXPECT_EQ(ui::VKEY_0, window_delegate->key_code());
+
+  event_generator.reset();
+  window.reset();
+  window_manager.reset();
+}
+
+TEST_F(CastWindowManagerAuraTest, WindowInputDisabled) {
+  std::unique_ptr<CastWindowManager> window_manager(
+      CastWindowManager::Create(false /* enable input */));
+
+  CastTestWindowDelegate* window_delegate = new CastTestWindowDelegate();
+  std::unique_ptr<aura::Window> window(new aura::Window(window_delegate));
+  window->Init(ui::LAYER_NOT_DRAWN);
+  window->SetName("event window");
+  window_manager->AddWindow(window.get());
+  window->SetBounds(gfx::Rect(0, 0, 1280, 720));
+  window->Show();
+  EXPECT_FALSE(window->IsRootWindow());
+  EXPECT_TRUE(window->GetHost());
+
+  // Confirm that the Aura focus client tracks window focus correctly.
+  aura::client::FocusClient* focus_client =
+      aura::client::GetFocusClient(window.get());
+  EXPECT_TRUE(focus_client);
+  EXPECT_FALSE(focus_client->GetFocusedWindow());
+  window->Focus();
+  EXPECT_EQ(window.get(), focus_client->GetFocusedWindow());
+
+  // Confirm that a key event is *not* delivered to the window when input is
+  // disabled.
+  std::unique_ptr<ui_controls::UIControlsAura> event_generator(
+      aura::test::CreateUIControlsAura(window->GetHost()));
+  EXPECT_TRUE(event_generator->SendKeyPress(nullptr, ui::VKEY_0, false, false,
+                                            false, false));
+  base::RunLoop().RunUntilIdle();

[sadrul, 2017/01/26 01:50:10]

ditto

[Joshua LeVasseur, 2017/01/26 02:51:01]

Acknowledged.

+  EXPECT_EQ(ui::VKEY_UNKNOWN, window_delegate->key_code());
+
+  event_generator.reset();
+  window.reset();
+  window_manager.reset();
+}
+
+}  // namespace test
+}  // namespace chromecast