Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp

Issue 2636253002: Handle nested position:sticky elements (Closed)
Patch Set: Offset rects correctly and accumulate correctly Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/page/scrolling/StickyPositionScrollingConstraints.h" 5 #include "core/page/scrolling/StickyPositionScrollingConstraints.h"
6 6
7 namespace blink { 7 namespace blink {
8 8
9 FloatSize StickyPositionScrollingConstraints::computeStickyOffset( 9 FloatSize StickyPositionScrollingConstraints::computeStickyOffset(
10 const FloatRect& viewportRect) const { 10 const FloatRect& viewportRect,
11 FloatRect boxRect = m_scrollContainerRelativeStickyBoxRect; 11 const FloatSize& accumulatedToCB,
12 const FloatSize& accumulatedToVP) {
13 // TODO(smcgruer): Explain what this is doing.
14 FloatRect stickyBoxRect = m_scrollContainerRelativeStickyBoxRect;
15 FloatRect containingBlockRect = m_scrollContainerRelativeContainingBlockRect;
16 stickyBoxRect.move(accumulatedToCB);
17 stickyBoxRect.move(accumulatedToVP);
18 containingBlockRect.move(accumulatedToVP);
19
20 FloatRect boxRect = stickyBoxRect;
12 21
13 if (hasAnchorEdge(AnchorEdgeRight)) { 22 if (hasAnchorEdge(AnchorEdgeRight)) {
14 float rightLimit = viewportRect.maxX() - m_rightOffset; 23 float rightLimit = viewportRect.maxX() - m_rightOffset;
15 float rightDelta = std::min<float>( 24 float rightDelta = std::min<float>(0, rightLimit - stickyBoxRect.maxX());
16 0, rightLimit - m_scrollContainerRelativeStickyBoxRect.maxX());
17 float availableSpace = 25 float availableSpace =
18 std::min<float>(0, m_scrollContainerRelativeContainingBlockRect.x() - 26 std::min<float>(0, containingBlockRect.x() - stickyBoxRect.x());
19 m_scrollContainerRelativeStickyBoxRect.x());
20 if (rightDelta < availableSpace) 27 if (rightDelta < availableSpace)
21 rightDelta = availableSpace; 28 rightDelta = availableSpace;
22 29
23 boxRect.move(rightDelta, 0); 30 boxRect.move(rightDelta, 0);
24 } 31 }
25 32
26 if (hasAnchorEdge(AnchorEdgeLeft)) { 33 if (hasAnchorEdge(AnchorEdgeLeft)) {
27 float leftLimit = viewportRect.x() + m_leftOffset; 34 float leftLimit = viewportRect.x() + m_leftOffset;
28 float leftDelta = std::max<float>( 35 float leftDelta = std::max<float>(0, leftLimit - stickyBoxRect.x());
29 0, leftLimit - m_scrollContainerRelativeStickyBoxRect.x());
30 float availableSpace = 36 float availableSpace =
31 std::max<float>(0, m_scrollContainerRelativeContainingBlockRect.maxX() - 37 std::max<float>(0, containingBlockRect.maxX() - stickyBoxRect.maxX());
32 m_scrollContainerRelativeStickyBoxRect.maxX());
33 if (leftDelta > availableSpace) 38 if (leftDelta > availableSpace)
34 leftDelta = availableSpace; 39 leftDelta = availableSpace;
35 40
36 boxRect.move(leftDelta, 0); 41 boxRect.move(leftDelta, 0);
37 } 42 }
38 43
39 if (hasAnchorEdge(AnchorEdgeBottom)) { 44 if (hasAnchorEdge(AnchorEdgeBottom)) {
40 float bottomLimit = viewportRect.maxY() - m_bottomOffset; 45 float bottomLimit = viewportRect.maxY() - m_bottomOffset;
41 float bottomDelta = std::min<float>( 46 float bottomDelta = std::min<float>(0, bottomLimit - stickyBoxRect.maxY());
42 0, bottomLimit - m_scrollContainerRelativeStickyBoxRect.maxY());
43 float availableSpace = 47 float availableSpace =
44 std::min<float>(0, m_scrollContainerRelativeContainingBlockRect.y() - 48 std::min<float>(0, containingBlockRect.y() - stickyBoxRect.y());
45 m_scrollContainerRelativeStickyBoxRect.y());
46 if (bottomDelta < availableSpace) 49 if (bottomDelta < availableSpace)
47 bottomDelta = availableSpace; 50 bottomDelta = availableSpace;
48 51
49 boxRect.move(0, bottomDelta); 52 boxRect.move(0, bottomDelta);
50 } 53 }
51 54
52 if (hasAnchorEdge(AnchorEdgeTop)) { 55 if (hasAnchorEdge(AnchorEdgeTop)) {
53 float topLimit = viewportRect.y() + m_topOffset; 56 float topLimit = viewportRect.y() + m_topOffset;
54 float topDelta = std::max<float>( 57 float topDelta = std::max<float>(0, topLimit - stickyBoxRect.y());
55 0, topLimit - m_scrollContainerRelativeStickyBoxRect.y());
56 float availableSpace = 58 float availableSpace =
57 std::max<float>(0, m_scrollContainerRelativeContainingBlockRect.maxY() - 59 std::max<float>(0, containingBlockRect.maxY() - stickyBoxRect.maxY());
58 m_scrollContainerRelativeStickyBoxRect.maxY()); 60
59 if (topDelta > availableSpace) 61 if (topDelta > availableSpace)
60 topDelta = availableSpace; 62 topDelta = availableSpace;
61 63
62 boxRect.move(0, topDelta); 64 boxRect.move(0, topDelta);
63 } 65 }
64 66
65 return boxRect.location() - m_scrollContainerRelativeStickyBoxRect.location(); 67 FloatSize stickyOffset = boxRect.location() - stickyBoxRect.location();
68
69 m_accumulatedStickyOffsetToContainingBlock.setWidth(accumulatedToCB.width() +
70 stickyOffset.width());
71 m_accumulatedStickyOffsetToContainingBlock.setHeight(
72 accumulatedToCB.height() + stickyOffset.height());
flackr 2017/01/20 02:42:44 FloatSize has arithmetic operators, should be able
smcgruer 2017/01/24 15:45:22 Done.
73
74 m_accumulatedStickyOffsetFromContainingBlockToScrollContainer.setWidth(
75 accumulatedToVP.width() + stickyOffset.width());
76 m_accumulatedStickyOffsetFromContainingBlockToScrollContainer.setHeight(
77 accumulatedToVP.height() + stickyOffset.height());
78
79 return stickyOffset;
66 } 80 }
67 81
68 } // namespace blink 82 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698