Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: third_party/WebKit/Source/core/page/scrolling/StickyPositionScrollingConstraints.cpp

Issue 2636253002: Handle nested position:sticky elements (Closed)
Patch Set: Remove accidental leftover whitespace Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/page/scrolling/StickyPositionScrollingConstraints.h" 5 #include "core/page/scrolling/StickyPositionScrollingConstraints.h"
6 6
7 namespace blink { 7 namespace blink {
8 8
9 FloatSize StickyPositionScrollingConstraints::computeStickyOffset( 9 FloatSize StickyPositionScrollingConstraints::computeStickyOffset(
10 const FloatRect& viewportRect) const { 10 const FloatRect& viewportRect,
11 FloatRect boxRect = m_scrollContainerRelativeStickyBoxRect; 11 const FloatSize& ancestorStickyBoxOffset,
12 const FloatSize& ancestorContainingBlockOffset) {
13 // Adjust the constraint rect locations based on our ancestor sticky elements,
14 // if they exist. These adjustments are necessary to avoid double offsetting
15 // in the case of nested sticky elements.
16 FloatRect stickyBoxRect = m_scrollContainerRelativeStickyBoxRect;
17 FloatRect containingBlockRect = m_scrollContainerRelativeContainingBlockRect;
18 stickyBoxRect.move(ancestorStickyBoxOffset);
19 stickyBoxRect.move(ancestorContainingBlockOffset);
20 containingBlockRect.move(ancestorContainingBlockOffset);
21
22 FloatRect boxRect = stickyBoxRect;
12 23
13 if (hasAnchorEdge(AnchorEdgeRight)) { 24 if (hasAnchorEdge(AnchorEdgeRight)) {
14 float rightLimit = viewportRect.maxX() - m_rightOffset; 25 float rightLimit = viewportRect.maxX() - m_rightOffset;
15 float rightDelta = std::min<float>( 26 float rightDelta = std::min<float>(0, rightLimit - stickyBoxRect.maxX());
16 0, rightLimit - m_scrollContainerRelativeStickyBoxRect.maxX());
17 float availableSpace = 27 float availableSpace =
18 std::min<float>(0, m_scrollContainerRelativeContainingBlockRect.x() - 28 std::min<float>(0, containingBlockRect.x() - stickyBoxRect.x());
19 m_scrollContainerRelativeStickyBoxRect.x());
20 if (rightDelta < availableSpace) 29 if (rightDelta < availableSpace)
21 rightDelta = availableSpace; 30 rightDelta = availableSpace;
22 31
23 boxRect.move(rightDelta, 0); 32 boxRect.move(rightDelta, 0);
24 } 33 }
25 34
26 if (hasAnchorEdge(AnchorEdgeLeft)) { 35 if (hasAnchorEdge(AnchorEdgeLeft)) {
27 float leftLimit = viewportRect.x() + m_leftOffset; 36 float leftLimit = viewportRect.x() + m_leftOffset;
28 float leftDelta = std::max<float>( 37 float leftDelta = std::max<float>(0, leftLimit - stickyBoxRect.x());
29 0, leftLimit - m_scrollContainerRelativeStickyBoxRect.x());
30 float availableSpace = 38 float availableSpace =
31 std::max<float>(0, m_scrollContainerRelativeContainingBlockRect.maxX() - 39 std::max<float>(0, containingBlockRect.maxX() - stickyBoxRect.maxX());
32 m_scrollContainerRelativeStickyBoxRect.maxX());
33 if (leftDelta > availableSpace) 40 if (leftDelta > availableSpace)
34 leftDelta = availableSpace; 41 leftDelta = availableSpace;
35 42
36 boxRect.move(leftDelta, 0); 43 boxRect.move(leftDelta, 0);
37 } 44 }
38 45
39 if (hasAnchorEdge(AnchorEdgeBottom)) { 46 if (hasAnchorEdge(AnchorEdgeBottom)) {
40 float bottomLimit = viewportRect.maxY() - m_bottomOffset; 47 float bottomLimit = viewportRect.maxY() - m_bottomOffset;
41 float bottomDelta = std::min<float>( 48 float bottomDelta = std::min<float>(0, bottomLimit - stickyBoxRect.maxY());
42 0, bottomLimit - m_scrollContainerRelativeStickyBoxRect.maxY());
43 float availableSpace = 49 float availableSpace =
44 std::min<float>(0, m_scrollContainerRelativeContainingBlockRect.y() - 50 std::min<float>(0, containingBlockRect.y() - stickyBoxRect.y());
45 m_scrollContainerRelativeStickyBoxRect.y());
46 if (bottomDelta < availableSpace) 51 if (bottomDelta < availableSpace)
47 bottomDelta = availableSpace; 52 bottomDelta = availableSpace;
48 53
49 boxRect.move(0, bottomDelta); 54 boxRect.move(0, bottomDelta);
50 } 55 }
51 56
52 if (hasAnchorEdge(AnchorEdgeTop)) { 57 if (hasAnchorEdge(AnchorEdgeTop)) {
53 float topLimit = viewportRect.y() + m_topOffset; 58 float topLimit = viewportRect.y() + m_topOffset;
54 float topDelta = std::max<float>( 59 float topDelta = std::max<float>(0, topLimit - stickyBoxRect.y());
55 0, topLimit - m_scrollContainerRelativeStickyBoxRect.y());
56 float availableSpace = 60 float availableSpace =
57 std::max<float>(0, m_scrollContainerRelativeContainingBlockRect.maxY() - 61 std::max<float>(0, containingBlockRect.maxY() - stickyBoxRect.maxY());
58 m_scrollContainerRelativeStickyBoxRect.maxY()); 62
59 if (topDelta > availableSpace) 63 if (topDelta > availableSpace)
60 topDelta = availableSpace; 64 topDelta = availableSpace;
61 65
62 boxRect.move(0, topDelta); 66 boxRect.move(0, topDelta);
63 } 67 }
64 68
65 return boxRect.location() - m_scrollContainerRelativeStickyBoxRect.location(); 69 FloatSize stickyOffset = boxRect.location() - stickyBoxRect.location();
70
71 m_totalStickyBoxStickyOffset = ancestorStickyBoxOffset + stickyOffset;
72 m_totalContainingBlockStickyOffset =
73 ancestorContainingBlockOffset + stickyOffset;
74
75 return stickyOffset;
66 } 76 }
67 77
68 } // namespace blink 78 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698