Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/android/url_utilities.cc

Issue 2636103002: [WebAPKs] Show minibar when WebAPK navigates outside scope specified in Web Manifest (Closed)
Patch Set: Merge branch 'master' into minibar Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/url_utilities.cc
diff --git a/chrome/browser/android/url_utilities.cc b/chrome/browser/android/url_utilities.cc
index cc7d3d1f63fb9a8ee1e22a72e24f1b250e482d16..1e28a53b87b05ffe2f869bd1b7bde13d49906b1a 100644
--- a/chrome/browser/android/url_utilities.cc
+++ b/chrome/browser/android/url_utilities.cc
@@ -6,6 +6,7 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
+#include "base/strings/string_util.h"
#include "components/google/core/browser/google_util.h"
#include "jni/UrlUtilities_jni.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
@@ -115,6 +116,17 @@ static jboolean IsGoogleHomePageUrl(JNIEnv* env,
return google_util::IsGoogleHomePageUrl(gurl);
}
+static jboolean IsUrlWithinScope(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jstring>& url,
+ const JavaParamRef<jstring>& scope_url) {
+ GURL gurl = ConvertJavaStringToGURL(env, url);
+ GURL gscope_url = ConvertJavaStringToGURL(env, scope_url);
+ return gurl.GetOrigin() == gscope_url.GetOrigin() &&
+ base::StartsWith(gurl.path(), gscope_url.path(),
+ base::CompareCase::SENSITIVE);
+}
+
static jboolean UrlsMatchIgnoringFragments(JNIEnv* env,
const JavaParamRef<jclass>& clazz,
const JavaParamRef<jstring>& url,
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698